In Xfwm4-4.13.0, you could click a window button, move the pointer away, then release the mouse button to abort the button press. This has been the way to cancel accidental button presses since at least Windows 95. In Xfwm4-4.13.1, this doesn't work anymore. As soon as you press the mouse button, it doesn't matter where you release it, it will go through.
git bisect: # possible first bad commit: [ef33ff7b2666ffc320700592fc7d4a300d5a8163] Replace XEvent with XfwmEvent + add xfwm_device_* grabs usage # possible first bad commit: [6013f1ee9b3831991db6a0fb896f20537532b6ce] device: Implement XI2 event handling
I can't trigger the bug with Xfwm4 4.13.x, but maybe I don't understand how to reproduce :/
Created attachment 8394 Maybe fix 14741, patch from ninetls Maybe a patch that can fix the issue, from ninetls few months ago. As this bug is a blocker for 4.14, I post this patch in the issue. Found it in my IRC backlog, pasting it before it disappears.
Hmm. Xfwm4-4.13.1 with compositing enabled. Repro: - Mousedown on close buttong of a window - Move cursor away from close button - Release mouse button Result: Window closes, Expectation: Window remains open
(In reply to Skunnyk from comment #3) > Created attachment 8394 > Maybe fix 14741, patch from ninetls > > Maybe a patch that can fix the issue, from ninetls few months ago. > As this bug is a blocker for 4.14, I post this patch in the issue. Found it > in my IRC backlog, pasting it before it disappears. Yay, this patch fixes this bug :)
I can confirm the patch fixes the problem, but no idea if there are any side effects.
Ok, I can reproduce, and the patch fix the bug !
Viktor Odintsev referenced this bugreport in commit f5da3d6622c22246ac367bd80fc24ea08c9baa2e events: Fix implicit grabs https://git.xfce.org/xfce/xfwm4/commit?id=f5da3d6622c22246ac367bd80fc24ea08c9baa2e
Confirmed working after this commit. Thanks!
Olivier Fourdan referenced this bugreport in commit 86c88ac79034240c1e43d4f5538857caab1abcab client: Fix enter/leave on buttons https://git.xfce.org/xfce/xfwm4/commit?id=86c88ac79034240c1e43d4f5538857caab1abcab
The fix was reverted in: https://git.xfce.org/xfce/xfwm4/commit?id=0f34265d83207ffe3486986d269af868cef29e30 The commit mentioned in comment 10 doesn't fix the problem for me.
That's right, but commit https://git.xfce.org/xfce/xfwm4/commit?id=f5da3d66 is unacceptable, so back to the drawing board.
Olivier Fourdan referenced this bugreport in commit e87422e55b5e861ae918fa053680abe9065e08e1 client: Check for enter/leave window on button events https://git.xfce.org/xfce/xfwm4/commit?id=e87422e55b5e861ae918fa053680abe9065e08e1
That should fix it for good,
*** Bug 15494 has been marked as a duplicate of this bug. ***