! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Does not display the entire file list
Status:
RESOLVED: FIXED

Comments

Description Max 2018-10-05 17:45:22 CEST
Buggy thunar 1.8.1. Does not display the entire file list.
Video:
https://www.youtube.com/watch?v=_KG-GslvxCI
Comment 1 alexxcons editbugs 2018-10-05 22:08:38 CEST
Not sure what exactly is the problem. You cannot scroll to the very right side ? Sorry, I cannot reproduce the bug... for me all files are displayed.

What exactly you are doing / which keys are pressed ?
Does it happen in all your folders, or just in this one ?
Does it always happen for you, or only occassionally ? 

May I ask you to provide a step-by step instruction to reproduce the bug ? I only can fix things which I can reproduce.
Comment 2 Max 2018-10-06 07:18:18 CEST
This happens in folders with a large number of files / folders and with long file / folder names.
Restarting thunar does not fix this.
Resizing the thunar corrects this.

There is a feeling that the thunar incorrectly calculates the size of the displayed field.
In the video, I'll show you how to catch the problem.

https://youtu.be/MJUQc01erGI
Comment 3 alexxcons editbugs 2018-10-10 23:29:02 CEST
Still cannot reproduce the bug, tried to use many files, and olnly a single one with very long name.

You are using compact list  view ? Does the bug as well show in icon view / detailed list view ?

Could you please try to provide a minimal reproducer ? ( e.g a minimal folder of empty files which already triggers the bug for you )
Comment 4 Max 2018-10-11 07:11:01 CEST
Yes,  I use the compact list  view 
step-by step instruction to reproduce the bug:

https://youtu.be/oqX0kVQoTnA
Comment 5 alexxcons editbugs 2018-10-11 21:56:36 CEST
Thanks for the reproducer !  But still no luck =(   ... possibly the theme / icon theme matters ... which do you use ?

Will as well ask a friend to try to reproduce.
Comment 6 Andre Miranda editbugs 2018-10-14 01:52:41 CEST
That reproducer is really helpful and your instructions clear, but unfortunately I can't reproduce with neither Thunar 1.8.1 and 1.8.2.

This is what is did:
- Closing all thunar windows and killing its daemon with $ thunar -q
- $ mkdir ~/test; cd ~/test; for i in {1..200}; do mktemp -p ./ XXXXXXXXXXXXXX; done
- Starting thunar from terminal with $ thunar ~/test

This is my configuration:
- Compact List view at 38% (last-compact-view-zoom-level)
- Toolbar style location selector
- Thunar window size is 837x529 (last-window-width/last-window-height)
- Shortcuts sidebar separator is at 208 (last-separator-position
- Greybird theme from git
- Moka icon theme from git
- gtk 3.24.1

You can view those values in Settings Editor (xfce4-settings-editor).
Comment 7 Max 2018-10-14 08:41:07 CEST
Yes, it is a buggy style.
"Graybird" and "high contrast" in the xubuntu 18.10
Comment 8 Andre Miranda editbugs 2018-10-15 00:55:08 CEST
Now that you mentioned I'm able easily to reproduce this bug on a Xubuntu 18.10 VM, with Greybird and Adwaita.
Still no luck on my system.
Comment 9 Theo Linkspfeifer editbugs 2019-06-15 22:40:02 CEST
If you play around with the height and width of the window, you should be able to trigger the bug with any theme.
Comment 10 Theo Linkspfeifer editbugs 2019-06-16 15:14:01 CEST
The bug is the result of this change:

https://git.xfce.org/xfce/exo/commit/?id=928a41aedd1b64fea3c1adb7991ccb6c2c9f5870
Comment 11 Andre Miranda editbugs 2019-06-17 01:02:55 CEST
With Xubuntu 18.10 and 19.04 the bug is easily reproducible with Greybird and Adwaita.
With xfce-test, which is based on Xubuntu 18.10, I can't reproduce.

(In reply to Theo Linkspfeifer from comment #10)
> The bug is the result of this change:
> 
> https://git.xfce.org/xfce/exo/commit/
> ?id=928a41aedd1b64fea3c1adb7991ccb6c2c9f5870

Did you bisect?
In any case it sounds suspect, since Sean reverted the part for preferred height calculation.
Comment 12 Theo Linkspfeifer editbugs 2019-06-22 14:28:58 CEST
*** Bug 15629 has been marked as a duplicate of this bug. ***
Comment 13 Forest 2019-09-17 11:49:41 CEST
I can reproduce this as well. It started when I upgraded from Xubuntu 18.04 to 19.04.

$ dpkg-query --show thunar  libexo-2-0
libexo-2-0:amd64	0.12.4-1
thunar	1.8.4-1ubuntu1
Comment 14 Forest 2019-09-17 12:42:14 CEST
Created attachment 9031 
Revert the remaining change from 928a41ae

Reverting 928a41ae (the part that wasn't already reverted) appears to fix the problem. I'll test some more and post again if the problem returns.
Comment 15 Forest 2019-09-20 09:40:45 CEST
I've been using my patch for a couple days without seeing the problem again. Can someone merge it?
Comment 16 Git Bot editbugs 2019-10-05 11:33:39 CEST
Sean Davis referenced this bugreport in commit 2fa107272265b2ee1da4e39ab3c59e58a9a98436

Fix issues with displaying icon view contents (bug #14737)

https://git.xfce.org/xfce/exo/commit?id=2fa107272265b2ee1da4e39ab3c59e58a9a98436
Comment 17 Sean Davis editbugs 2019-10-05 11:34:06 CEST
Patch applied above. Thanks everyone!

Bug #14737

Reported by:
Max
Reported on: 2018-10-05
Last modified on: 2019-10-05
Duplicates (1):

People

Assignee:
Xfce Bug Triage
CC List:
8 users

Version

Version:
unspecified

Attachments

Additional information