! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Entry name for xfce4-terminal-settings in Whisker menu is misleading


Description Maycne Sonahoz 2018-06-15 22:17:59 CEST
Created attachment 7786 
One is the actual Terminal, the other is the Settings.

Using the Whisker menu, xfce4-terminal and xfce4-terminal-settings share the same name.
When navigating through the menus, one can tell them apart since the Terminal is in System, and the Settings in Preferences.
But when searching the "terminal" through the search function, both results show up without anything to tell them apart, as seen in the joined picture.

I suggest to make those entries have different names.

On Manjaro x64
xfce4-whiskermenu-plugin 2.2.0-1

Comment 1 Graeme Gott editbugs 2018-06-16 00:15:34 CEST
The entry name is not controlled by Whisker Menu. Whisker Menu just loads the contents of the menu from garcon, and has no idea what menu items there are. The problem is caused by the xfce4-terminal.desktop file and the xfce4-terminal-settings.desktop file both having the same entry name, but that is not something Whisker Menu can change. The Xfce terminal needs to change one of the entry names in its desktop files for it to show up differently in Whisker Menu. You should report this to the Xfce terminal.
Comment 2 Igor editbugs 2018-06-18 15:11:57 CEST
When creating the xfce4-terminal-settings.desktop file, I followed the existing approach: for example, the Settings entry for Thunar is called "File Manager", not "File Manager Settings"; the entry for WM is just "Window Manager". So, I guess, adding word "Settings" to the names would be excessive since those entries are already under the Settings menu.
Comment 3 Igor editbugs 2018-06-18 15:18:16 CEST
What I could do is to change the Comment field in the xfce4-terminal-settings.desktop file so it would say something like "Configure Xfce Terminal", what do you think?
Comment 4 Maycne Sonahoz 2018-06-18 18:51:01 CEST
(In reply to Igor from comment #3)
> What I could do is to change the Comment field in the
> xfce4-terminal-settings.desktop file so it would say something like
> "Configure Xfce Terminal", what do you think?

That would work. Furthermore, since you mention Thunar as example, i see it also uses that approach.
Comment 5 Git Bot editbugs 2018-06-18 19:06:43 CEST
Igor referenced this bugreport in commit 17148b312d6e3db34286ac7203c8b32be418ddb0

Distinguish terminal settings from the actual terminal in the menu

Comment 6 Igor editbugs 2018-06-18 19:07:05 CEST
Fixed, thank you!
Comment 7 Maycne Sonahoz 2018-06-18 19:22:41 CEST
Thanks a lot. :)
Comment 8 Igor editbugs 2019-07-02 19:41:29 CEST
*** Bug 15672 has been marked as a duplicate of this bug. ***
Comment 9 bikepunk 2020-04-05 06:05:51 CEST
For me, the fix doesn't work.

tested in Xubuntu 20.04 Beta

Whisker using the search fonction does't display the "Comment=Configure Xfce Terminal"
It displays only the logo and the "Xfce terminal" name. That's super misleading.

IMHO "Xfce terminal" is not an appropriate name for a "xfce4-terminal --preferences" command.
as well as the logo to access configuration shall not be the same as the actual "xfce4-terminal"
Comment 10 bikepunk 2020-04-05 06:26:09 CEST

the terminal icon could be used with a smaller "settings" icon or (may be more explicit) a wrench or even a cog icon on top to explicit that is dealing with configuration.
Comment 11 Yousuf 'Jay' Philips 2020-04-06 21:23:12 CEST
I've filed a new bug to fix this issue in bug 16647.
Comment 12 bikepunk 2020-04-09 14:01:29 CEST
After some thinking, I would be more radical and just remove

-I don't know anyone actually using it (people open the terminal, then click Edit >Preferences)

-it doesn't exist in gnome terminal (https://gitlab.gnome.org/GNOME/gnome-terminal)

That would fix the misleading problem
Comment 13 Yousuf 'Jay' Philips 2020-04-09 14:05:01 CEST
Removing it isnt an option, as its an entry in Settings Manager.

Comment 14 bikepunk 2020-04-09 18:17:40 CEST
removing the entry in Settings Manager wouldn't be a problem to me.

There is no "Transmission" or "firefox" in Settings Manager and I don't miss them.
Comment 15 Yousuf 'Jay' Philips 2020-04-09 21:06:03 CEST
Those aren't Xfce's desktop environment specific apps, so obviously their settings wouldnt be in settings manager.
Comment 16 Igor editbugs 2020-04-20 18:15:49 CEST
As mentioned above, Firefox and Transmission aren't Xfce apps. While Xfce-terminal, as well as Thunar, are Xfce apps and have entries in the Settings Manager.

Let's switch to bug #16647 to discuss the proposal.

Bug #14456

Reported by:
Maycne Sonahoz
Reported on: 2018-06-15
Last modified on: 2020-04-20
Duplicates (1):
  • 15672 .desktop shortcuts looks almost identical


CC List:
5 users




Additional information