! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Folder named "Trash" is localized
Status:
RESOLVED: FIXED

Comments

Description casi 2018-02-12 18:42:07 CET
Created attachment 7591 
Reproduced the bug

I've been missing my folder with Trash music, until I found out that Thunar localizes its name. "Papierkorb" is the German name for "trash".

That localization is not intended (at least for me).
Comment 1 Andre Miranda editbugs 2018-02-12 22:16:56 CET
Created attachment 7594 
patch

This bug was introduced by Bug #13409's patch.
If you're able, please test the attached patch before I push this patch to master and the xfce-4.12 branch.

Thanks for reporting!
Comment 2 ToZ editbugs 2018-02-13 01:06:33 CET
Created attachment 7595 
Re-created patch

I tested the fixes and they work. Kind of.

The attached patch wouldn't properly apply to git for some reason. I re-created the fixes in the attached patch and they worked.

Secondly, after the patch, I get a large number of the same message on the terminal that I wasn't getting prior to the patch.

(thunar:30449): GLib-GIO-CRITICAL **: g_file_get_uri: assertion 'G_IS_FILE (file)' failed
Comment 3 Andre Miranda editbugs 2018-02-13 02:17:00 CET
Created attachment 7597 
Updated patch

I forgot to run git pull before creating the patch, but even after that it applies correctly, who knows...
But thanks for testing, the previous patch was wrong, it tried to pass ThunarFile as GFile in thunar_g_file_get_display_name.
Comment 4 ToZ editbugs 2018-02-13 03:05:46 CET
This new patch works perfectly. No more errant messages. Thanks.
Comment 5 alexxcons editbugs 2018-02-13 20:10:16 CET
Funny easteregg bug this is ;)

The patch works nice for me as well !
Comment 6 Git Bot editbugs 2018-02-14 01:10:49 CET
Andre Miranda referenced this bugreport in commit c7c6e7dbe9a3c3d7c2fbc2156b6c16d7c0f71ae5

Do not translate "Trash" files and folders (Bug #14211)

https://git.xfce.org/xfce/thunar/commit?id=c7c6e7dbe9a3c3d7c2fbc2156b6c16d7c0f71ae5
Comment 7 Git Bot editbugs 2018-02-14 01:11:56 CET
Andre Miranda referenced this bugreport in commit fdd834727cad191b95d705b426fba804363f7d92

Do not translate "Trash" files and folders (Bug #14211)

https://git.xfce.org/xfce/thunar/commit?id=fdd834727cad191b95d705b426fba804363f7d92
Comment 8 Andre Miranda editbugs 2018-02-14 01:21:39 CET
The fix will be available in 1.7.1 and 1.6.14, thank you all for reporting and testing.

Bug #14211

Reported by:
casi
Reported on: 2018-02-12
Last modified on: 2018-02-14

People

Assignee:
Andre Miranda
CC List:
5 users

Version

Version:
1.6.13

Attachments

Reproduced the bug (18.87 KB, image/png)
2018-02-12 18:42 CET , casi
no flags
patch (3.86 KB, patch)
2018-02-12 22:16 CET , Andre Miranda
no flags
Re-created patch (3.41 KB, patch)
2018-02-13 01:06 CET , ToZ
no flags
Updated patch (4.02 KB, patch)
2018-02-13 02:17 CET , Andre Miranda
no flags

Additional information