! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Drag and Drop in GtkPlug


Description Stefan Berzl 2017-09-16 02:05:31 CEST
Created attachment 7319 
Workaround for dnd in sockets and plugs.

Drag and Drop inside GtkSocket and GtkPlug doesn't work correctly. There are
actually many bugs concerning event propagation between GtkSocket and
GtkPlug. For example:

Something along these lines happens when xfwm4-settings is embedded into
xfce4-settings-manager. The drag_end handler isn't called when a button from
"Button layout" is dragged. Fortunately, this only happens when the button
is dragged onto the the specified drag area. All we need to do is move the
gtk_widget_show function at the end of the drag-data-received handler.
Comment 1 Stefan Berzl 2017-09-17 03:01:03 CEST
I forgot to the describe the problem. Not calling the drag_end handler on the
buttons hides them and  doesn't show them again. Meaning you have to
reaload the menu to relocate stuff like the close and minimize button.
Comment 2 Theo Linkspfeifer editbugs 2020-04-02 12:05:46 CEST
Thank you for the patch. I have tested it and it does fix the problem.
Comment 3 Theo Linkspfeifer editbugs 2020-04-02 12:07:40 CEST
*** Bug 15733 has been marked as a duplicate of this bug. ***
Comment 4 Git Bot editbugs 2020-04-05 17:53:31 CEST
Stefan Berzl referenced this bugreport in commit 1e3dd9c8a5510144676ac1df4c4a21ca88a69bf5

settings-dialog: Fix drag and drop of buttons

Comment 5 Git Bot editbugs 2020-04-11 17:59:08 CEST
Stefan Berzl referenced this bugreport in commit 629c8461c646eca5bad97e5cb59e298e53e76872

settings-dialog: Fix drag and drop of buttons

Comment 6 Olivier Fourdan editbugs 2020-05-06 15:13:52 CEST
*** Bug 16804 has been marked as a duplicate of this bug. ***

Bug #13861

Reported by:
Stefan Berzl
Reported on: 2017-09-16
Last modified on: 2020-05-06
Duplicates (2):
  • 15733 moving titlebar buttons makes them disappear from settings UI
  • 16804 Style - Button Layout - drag buttons


Olivier Fourdan
CC List:
2 users




Additional information