! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Configure text color
Status:
RESOLVED: FIXED
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description dani 2017-05-10 15:54:00 CEST
Same that
https://bugzilla.xfce.org/show_bug.cgi?id=13565
Comment 1 Fabian Nowak editbugs 2017-05-10 22:48:03 CEST
In the screenshot, the color for the displayed sensor is green. It can also be changed in the options dialog.

Admittedly, the text color in front of the values is black always, same applies for the general plugin label "Sensors".

Having a seperate color chooser for the latter label is completely out of sense.

The text label for the values looks nicer in black on light themes. Maybe a second option "colorize sensor label texts as well" might make sense. Or as an alternative to try to invert the background color.

Another option is extending the already delivered CSS file. 

Which one do you think is best for users?
Comment 2 dani 2017-05-11 09:23:08 CEST
I think the best option is to put an option to select the color of the label (in properties-Tab view, for example).
Thanks.
Comment 3 Fabian Nowak editbugs 2017-05-11 20:54:52 CEST
(In reply to dani from comment #2)
> I think the best option is to put an option to select the color of the label
> (in properties-Tab view, for example).
> Thanks.

To be more precise, this is the worst option. It is already possible to change the color of each individual displayed sensor feature's value. That's why I outlined the three other possibilities: Apply sensor feature color to labels as well; Option for inverting all text colors; or CSS file based.
Comment 4 Fabian Nowak editbugs 2017-05-22 21:34:44 CEST
The presented option for the netload-plugin is not a viable way for the sensors plugin. The latter has already a plethora of options, including the possibility to change the colors of the values in text mode, bar colors in bar mode, and font colors in tacho mode. Committed with bb47d05..0170b4b is that the text color is also applied to each sensor feature's label. Trying with theme xfce-dusk, the plugin's general label is colored white automatically; so there is no need to have another option as well. Same autoinverting applies for the bar labels as well.

Bug #13566

Reported by:
dani
Reported on: 2017-05-10
Last modified on: 2017-05-22

People

Assignee:
Fabian Nowak
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information