! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Configure text color
Status:
RESOLVED: FIXED
Product:
Xfce4-cpufreq-plugin
Component:
General

Comments

Description dani 2017-05-10 15:48:39 CEST
Created attachment 7104 
image cpufreq icon

With dark panel.
Font color for cpufreq (black) it is difficult to see
Comment 1 dani 2017-05-10 15:51:43 CEST
One possible solution is to add a light background.
Another add an option to choose the font color.
Comment 2 Armando Ortega 2017-05-22 13:59:54 CEST
Created attachment 7116 
Adds chose color option

Hi, I hope this patch works.
Comment 3 Andre Miranda editbugs 2017-06-05 15:18:40 CEST
Hi Armando, nice patch, though I think a Color Button[1] would be more user friendly.
If you're gentle enough to submit an updated patch, I'd be gentle enough to review and push to master ASAP ;)
Just be sure to generate a patch from a commit (with a message like Add option to configure text color bug #13565) and do not include translation files, they are magically handled =)

1 - https://developer.gnome.org/gtk3/stable/GtkColorButton.html
Comment 4 Armando Ortega 2017-06-08 21:30:01 CEST
Created attachment 7162 
Add option to configure text color

You are correct, Color Button is more user friendly.

I think I've generated the patch correctly.

Many thanks.
Comment 5 Git Bot editbugs 2017-06-09 03:42:32 CEST
Andre Miranda referenced this bugreport in commit 3c76cd9806638eab2a7d04714eb9c93dcb9a55dd

Add option to configure text color bug #13565

https://git.xfce.org/panel-plugins/xfce4-cpufreq-plugin/commit?id=3c76cd9806638eab2a7d04714eb9c93dcb9a55dd
Comment 6 Andre Miranda editbugs 2017-06-09 03:43:58 CEST
I reviewed your patch and I had to make a few changes, therefore I couldn't commit it right away, I hope you don't mind.
Once again thanks!

Bug #13565

Reported by:
dani
Reported on: 2017-05-10
Last modified on: 2017-06-09

People

Assignee:
Harald Judt
CC List:
3 users

Version

Attachments

image cpufreq icon (3.68 KB, image/png)
2017-05-10 15:48 CEST , dani
no flags
Adds chose color option (6.43 KB, patch)
2017-05-22 13:59 CEST , Armando Ortega
no flags
Add option to configure text color (5.87 KB, patch)
2017-06-08 21:30 CEST , Armando Ortega
no flags

Additional information