! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fails to copy image to clipboard
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Clipboard Manager

Comments

Description Andre Miranda editbugs 2017-04-29 02:24:58 CEST
There are some bugs reported to xfce4-screenshooter about copy to clipboard not working for large resolutions:
https://bugzilla.xfce.org/show_bug.cgi?id=13342
https://bugzilla.xfce.org/show_bug.cgi?id=13395
https://bugzilla.xfce.org/show_bug.cgi?id=10426
https://bugzilla.xfce.org/show_bug.cgi?id=12704

gnome-screenshot is also affected if started with -c flag or in interactive mode if you press the copy to clipboard button then close the app before pasting.
At first I thought it was something related to gtk_clipboard_set_image, but this problem doesn't happen when running /usr/lib/gnome-settings-daemon/gsd-clipboard instead of xfsettingsd.
Comment 1 Kristian Angelov 2018-12-29 17:20:42 CET
This issue doesnt seem to be limited to just images but generally very large buffers. Copying some very large pieces of text data fails as well. 

I looked through the gnome clipboard and xfce source. Unsure which one of the two is the fork, but they obviously share the same codebase. I suggest the changes from gnome-settings-daemon get picked into the xfsettingsd clipboardmanager.
Comment 2 Andre Miranda editbugs 2018-12-30 18:20:19 CET
Since you read both codebases, are you able to identify what could be cause and perhaps provide a patch?
Comment 3 Kristian Angelov 2018-12-31 18:04:35 CET
(In reply to Andre Miranda from comment #2)
> Since you read both codebases, are you able to identify what could be cause
> and perhaps provide a patch?

I don't see a cause at first glance. Will need to start testing things out and that's probably outside my field of expertise.
Comment 4 Git Bot editbugs 2019-04-21 18:47:43 CEST
Andre Miranda referenced this bugreport in commit d7ba62f33965e5ba0601fdb7ee13def9c6e4f1bf

Fix incremental sending from the clipboard manager (Bug #13537)

https://git.xfce.org/xfce/xfce4-settings/commit?id=d7ba62f33965e5ba0601fdb7ee13def9c6e4f1bf
Comment 5 Andre Miranda editbugs 2019-04-21 18:51:13 CEST
Luckily gsd-clipboard code didn't change much since 2011, so finding the fix for this was much easier than I thought.
Comment 6 lockywolf 2019-04-22 05:18:49 CEST
I'll try to test it today-tomorrow.
Comment 7 lockywolf 2019-04-23 04:20:26 CEST
For some reason I can't reproduce it now. Old versions of xfce4-settings and xfce4-screenshooter work just fine.

The only (but huge!) change I made in these two days -- I have changed my root fs from btrfs to ext4.
"After" doesn't mean "because of", but this does add to my suspicion towards btrfs, since I had quite a few mysterious glitches on it.

If I ever see this issue again, I'll try to compare these versions.
Comment 8 David Ayers 2019-04-23 12:57:35 CEST
I could also only reproduce this with screen shots taken with a sufficiently high resolution aka buffer.
Comment 9 Andre Miranda editbugs 2019-04-23 17:07:23 CEST
(In reply to David Ayers from comment #8)
> I could also only reproduce this with screen shots taken with a sufficiently
> high resolution aka buffer.

Anything larger than 1920x1080 is enough to reproduce this bug, for instance a laptop connected to an external display.
Comment 10 Kristian Angelov 2019-04-24 01:36:17 CEST
Happens to me on 1366x768 resolution screenshots, as well as images copied directly from various programs (chromium/firefox right click copy; gimp ctrl+c copy)
Maybe Xorg's max buffer sizes are dependent on memory size?
Comment 11 Andre Miranda editbugs 2019-04-24 02:49:58 CEST
(In reply to Kristian Angelov from comment #10)
> Happens to me on 1366x768 resolution screenshots, as well as images copied
> directly from various programs (chromium/firefox right click copy; gimp
> ctrl+c copy)
> Maybe Xorg's max buffer sizes are dependent on memory size?

The fix is already in git master, did you try it?
Comment 12 ondondil 2019-04-25 19:54:41 CEST
I could reliably trigger the bug in Xubuntu Disco Dingo (xfce4-settings 4.13.4). After installing daily build of xfce4-settings from xubuntu-dev PPA it seems that the bug is gone. Looks like the fix worked. Thanks!
Comment 13 Andre Miranda editbugs 2019-04-25 19:55:42 CEST
(In reply to ondondil from comment #12)
> I could reliably trigger the bug in Xubuntu Disco Dingo (xfce4-settings
> 4.13.4). After installing daily build of xfce4-settings from xubuntu-dev PPA
> it seems that the bug is gone. Looks like the fix worked. Thanks!

You're welcome, thanks for the feedback.

Bug #13537

Reported by:
Andre Miranda
Reported on: 2017-04-29
Last modified on: 2019-04-25

People

Assignee:
Nick Schermer
CC List:
6 users

Version

Version:
4.13.0

Attachments

Additional information