! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Desktop menu pops up on wrong display.
Status:
RESOLVED: MOVED
Product:
Xfdesktop
Component:
General

Comments

Description Grant Edwards 2015-07-17 21:16:03 CEST
I have an XFCE setup with three X11 displays (:0.0, :0.1, :0.2) and a desktop on each.  [Not a single desktop spread across all three displays.]

When I "right click" on the desktop, the desktop menu sometimes pops up on the wrong display.  Instead of popping up where I did the "right click", it seems to pop up on the screen on which I most recently did a "left-click".  If I always "left-click" on the desktop a couple times before the "right-click", then the menu pops up where it should.

This problem makes xfdesktop difficult to use in a multi-display setup.

Reverting from xfdesktop 4.12 to 4.10 fixes this problem.
Comment 1 Grant Edwards 2015-07-17 22:06:43 CEST
More specific version info...

I noticed this bug in 4.12.2 (which is not available as a choice in bugzilla).  

The bug is not present in 4.10.2 (I haven't tried 4.10.3, 4.12.1 or 4.12.0)
Comment 2 Michael Widlok 2015-09-21 10:51:40 CEST
In my case (4 screens, 2 desktops) pop-up menu is always on first desktop, it is never shown on the second - wherever I clicked before. Everything else as in previous reports. Downgrade to 4.10.2 fixes the problem.
Comment 3 Nathan Neulinger 2015-11-09 18:38:05 CET
Seeing this on Ubuntu 15.10 with 4.12.3 as well. Had working config with 4.10.3 on Fedora 20 though. 

Had filed an Ubuntu bug before I saw this one: 

https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/1514527
Comment 4 Nathan Neulinger 2015-11-09 19:18:16 CET
Interesting, in my case, reverting just xfdesktop to 4.10 from ubuntu 14.04 does NOT fix the issue. 

Grant, did you downgrade all of xfce, or just xfdesktop?
Comment 5 Grant Edwards 2015-11-09 19:28:59 CET
IIRC, I first tried downgrading just the desktop. But,q because of
library dependancies ended up downgrading 1-2 other things.

Here's what I'm current runing on Gentoo:

x11-themes/gtk-engines-xfce-3.2.0-r200
x11-themes/xfce-gant-icon-theme-3.9_p6
x11-themes/xfwm4-themes-4.10.0
xfce-base/libxfce4ui-4.12.1-r2
xfce-base/libxfce4util-4.12.1
xfce-base/xfce4-appfinder-4.12.0-r1
xfce-base/xfce4-meta-4.10
xfce-base/xfce4-panel-4.12.0
xfce-base/xfce4-session-4.12.1
xfce-base/xfce4-settings-4.12.0
xfce-base/xfconf-4.12.0-r1
xfce-base/xfdesktop-4.10.2
xfce-base/xfwm4-4.12.3
xfce-extra/xfce4-clipman-plugin-1.2.6
xfce-extra/xfce4-mixer-4.11.0
xfce-extra/xfce4-notifyd-0.2.4
Comment 6 Nathan Neulinger 2015-11-11 16:01:02 CET
Just did some further testing that may help track this down. Reason downgrading on ubuntu didn't help is that I wasn't paying close attention and downgraded to 4.11, and not 4.10 since 4.10 wasn't in the package repository. 

What this indicates to me is that the problem was introduced between 4.10.x and 4.11.6. 

Now that I can reproduce the fix, I'll take a look and see if I can bisect for you. (Assuming I can get xfdesktop built.)
Comment 7 Nathan Neulinger 2015-11-11 16:48:35 CET
Here's when it broke:

commit c102646246a09f93431c37499b40f9e49ae1b783
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Tue Oct 8 14:56:35 2013 +0300

    Right click issues persist (Bug 9323)
    
    This patch uses the gtk_grab_add/remove functions to handle grabs
    prior to a menu popup. Additionally, the menu will pop up on the
    button press event if there's no conflict (i.e. right click DND).


Trying to see if I can figure out the specific problem, but if someone familiar with this code could
Comment 8 Nathan Neulinger 2015-11-11 17:01:31 CET
My guess on this is that the underlying problem is the change from 

-    if(gtk_widget_has_screen(GTK_WIDGET(desktop)))
-        screen = gtk_widget_get_screen(GTK_WIDGET(desktop));
-    else
-        screen = gdk_display_get_default_screen(gdk_display_get_default());

to just using the gtk_grab functions. That altered code likely isn't tolerating a different display for the widget...
Comment 9 Nathan Neulinger 2015-12-11 16:10:22 CET
Is anyone looking at this issue?
Comment 10 Grant Edwards 2016-09-24 00:24:52 CEST
Is this till broken?

I'm still running xfdesktop 4.10 to avoid this problem, but that is starting to cause problems.
Comment 11 Git Bot editbugs 2020-05-26 00:28:33 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfdesktop/-/issues/19.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12076

Reported by:
Grant Edwards
Reported on: 2015-07-17
Last modified on: 2020-05-26

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
4.12.1

Attachments

Additional information