Comment 1 Eric Koegel 2013-08-30 08:13:24 CEST

A fix has been pushed to master, http://git.xfce.org/xfce/xfdesktop/commit/?id=af35570486899140425227767e27385fb5b3fa70

Thanks a lot Eric. Looking forwards to trying your patch as soon as its available by either my distro or a PPA.

This fix probably introduced a new complication, when right-clicking a desktop without icons (Desktop -> Icons -> Icon type: None):
After a right-click on the desktop the mouse cursor changes for a short time to the grab modus and then back to the normal cursor. Sometimes, if the mouse moves a few pixels in this moment, the first (or the last, depending on the popup direction) entry of menu is selected and executed.

This was not a problem until I updated to 4.11.

I'm still noticing this same bug in version 4.11.0.

Comment 5 Eric Koegel 2013-10-08 06:55:23 CEST

Reopening bug.

Comment 6 Eric Koegel 2013-10-08 07:06:12 CEST

Created attachment 5175 
Right click issues

This patch should hopefully fix both the desktop popup regression with no icons on the desktop and the right click not registering. Can you please test this out?
Thanks!

The patch does fix the regression when using the desktop without icons. I can't say anything about the issue, that right-clicks are not registering, since I never (even with previous versions) could reproduce it (I'm wondering, if this is a special case, where no release event is issued).

However all told I'm not sure if we've reached a satisfying solution. On the good side there is now a consistent right-click behavior of desktop with or without icons. But on the other side I see following disadvantages:
- menu popup on right-click release is different from every other application (including the xfce core apps)
- it introduces a short delay (depending on how fast the user releases the button), which may feel like slow reaction of the desktop
- opening the menu, selecting, and executing an entry in one move (by keeping the right mouse button pressed) isn't possible anymore
- grabbing a desktop item with the right mouse button seems weird (especially when grabbing with right or left leads to a slightly different behavior)

Anyway, thanks for looking into it.

Comment 8 Eric Koegel 2013-10-08 14:10:04 CEST

Created attachment 5177 
Right click revision

Thanks for the quick reply. This patch will pop up the menu at button press again. Let me know if this causes the execute the first item regression for you.
The grabbing with the right mouse is primarly to support right click DND where it pops up a menu (asking if you want to move, copy, link, or cancel) if it's dragged anywhere except to another empty spot on the desktop.

Last patch did it. For my part this issue is solved. Thanks.

> The grabbing with the right mouse is primarly to support right click DND
> where it pops up a menu (asking if you want to move, copy, link, or cancel)
> if it's dragged anywhere except to another empty spot on the desktop.
Ah, I see, but it isn't implemented yet? In a quick test I did not get any menu. The grabbed item just clings to my cursor until I left click.

Unfortunately I've found another issue with the patched version. If one binds a shortcut to xfdesktop --menu, it only pops up, if the time between press and release event is short enough. (Same applies to the windowlist menu).

Comment 11 Eric Koegel 2013-10-27 11:21:29 CET

Created attachment 5205 
Fix menu popups via the command line

Thanks for pointing that out. This patch should allow the --menu and --windowlist commands to work again. 
It adds to 5177 which was pushed to master in http://git.xfce.org/xfce/xfdesktop/commit/?id=c102646246a09f93431c37499b40f9e49ae1b783

(In reply to Eric Koegel from comment #11)
> Created attachment 5205 
> Fix menu popups via the command line
> 
> Thanks for pointing that out. This patch should allow the --menu and
> --windowlist commands to work again. 
> It adds to 5177 which was pushed to master in
> http://git.xfce.org/xfce/xfdesktop/commit/
> ?id=c102646246a09f93431c37499b40f9e49ae1b783

Looks good for me. Thanks.

Comment 13 Eric Koegel 2013-10-29 16:44:24 CET

Pushed to master: http://git.xfce.org/xfce/xfdesktop/commit/?id=82b385d0e243dc26429b8cc647630f18107ebe6a

Comment 14 Eric Koegel 2013-11-27 01:36:30 CET

As the fix has been pushed to master, closing bug report.