! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Missing icons for various things
Status:
RESOLVED: FIXED

Comments

Description Robby Workman editbugs 2015-02-27 05:49:17 CET
Created attachment 6006 
Don't use GTK_STOCK icons

When using new adwaita-icon-theme 3.14.x, regular directories do not have icons. I do not have any network stuff to check, but here are a couple of potentially related reports:
https://bugzilla.xfce.org/show_bug.cgi?id=10361
https://bugzilla.xfce.org/show_bug.cgi?id=9988

I pulled a few patches from Mageia's srpm and I'll attach them here:
* Sun Feb 15 2015 wally <wally> 1.6.4-3.mga5
+ Revision: 814986
- add patch to fix icon issue when oxygen-icon-theme is used

* Sun Feb 15 2015 wally <wally> 1.6.4-2.mga5
+ Revision: 814982
- add patches to fix some missing icons when adwaita-icon-theme is used
Comment 1 Robby Workman editbugs 2015-02-27 05:50:09 CET
Created attachment 6007 
Fix folder icon lookup
Comment 2 Robby Workman editbugs 2015-02-27 05:53:28 CET
Created attachment 6008 
Fix wallpaper plugin icon
Comment 3 Robby Workman editbugs 2015-02-27 06:18:28 CET
For the sake of clarity, these are *not* my patches; "wally" from Mageia (assuming he wrote them) deserves that credit.
I contacted him on IRC and asked him to follow up here.
In the meantime, I still see the behavior reported in 10361 - will try to figure out what's going on there.
Comment 4 Robby Workman editbugs 2015-02-27 16:00:34 CET
Created attachment 6010 
Fix icon name usage
Comment 5 Robby Workman editbugs 2015-02-27 16:02:21 CET
Created attachment 6011 
Fix some GTK_STOCK icon usage
Comment 6 Robby Workman editbugs 2015-02-27 16:04:31 CET
Created attachment 6012 
Fix wallpaper plugin icon
Comment 7 Robby Workman editbugs 2015-02-27 16:06:49 CET
Sorry for the noise, but I just attached ready-to-merge patches in git format with correct attribution after talking to wally on IRC:

14:12 < wally_> rworkman: sending those patches to upstream is in my TODO, but I've been a bit lazy lately
14:13 < wally_> rworkman: I can probably make git formatted patches, but not right now, maybe on monday
14:14 < wally_> rworkman: but if you want, you can also do it. you use my real name (from /whois) and mageia.org email addres
14:15 < wally_> which is wally@mageia.org
Comment 8 Harald Judt editbugs 2015-02-28 13:38:05 CET
Fixed in git master. Thanks for the patches.

Bug #11608

Reported by:
Robby Workman
Reported on: 2015-02-27
Last modified on: 2015-02-28

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Attachments

Don't use GTK_STOCK icons (8.87 KB, patch)
2015-02-27 05:49 CET , Robby Workman
no flags
Fix folder icon lookup (526 bytes, patch)
2015-02-27 05:50 CET , Robby Workman
no flags
Fix wallpaper plugin icon (835 bytes, patch)
2015-02-27 05:53 CET , Robby Workman
no flags
Fix icon name usage (861 bytes, patch)
2015-02-27 16:00 CET , Robby Workman
no flags
Fix some GTK_STOCK icon usage (9.34 KB, patch)
2015-02-27 16:02 CET , Robby Workman
no flags
Fix wallpaper plugin icon (1.17 KB, patch)
2015-02-27 16:04 CET , Robby Workman
no flags

Additional information