11442 – [Regression] File selection very slow with Thunar 1.6.4

[Regression] File selection very slow with Thunar 1.6.4

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
major

Product:
Thunar

Component:

General

Comments

Description Thomas Lange 2015-01-10 17:51:27 CET

Created attachment 5853 
Screencast which shows the issue

With Thunar 1.6.4 the selection of files became very slow.
Downgrading to 1.6.3 restores the previous performance.

Steps to reproduce:
1. Open a directory with many containing files (like "/usr/bin/")
2. Maximize Thunar
3. Select files by mouse dragging

An example screencast is attached.
Here only few files are selected.
The performance decreases even more with more files.

Selecting all the files with CTRL+A became also much slower.
With "/usr/bin/" on a SSD it needs maybe two seconds.
Thunar 1.6.3 responds nearly instantly.

System information:
- Arch Linux
- Thunar 1.6.4
- GTK 2.24.25

Comment 1 Harald Judt 2015-01-13 18:51:56 CET

Can you bisect to find the offending commit?

Comment 2 Thomas Lange 2015-01-13 23:49:41 CET

Created attachment 5864 
git-bisect.log

Comment 3 Thomas Lange 2015-01-13 23:52:37 CET

The culprit is commit http://git.xfce.org/xfce/thunar/commit/?id=78a3cba27c.

Simply reverting this commit alone restores the old performance.

Comment 4 Harald Judt 2015-01-14 08:54:56 CET

Thanks, confirmed. For reference, see bug #10557 and https://bugs.freedesktop.org/show_bug.cgi?id=72551. Which version of libXrender, renderproto and cairo are you using?

Comment 5 Thomas Lange 2015-01-14 18:15:24 CET

Thanks to Arch Linux, always the latest version. ;)

libxrender 0.9.8
renderproto 0.11.1
cairo 1.14.0

Comment 6 Thomas Lange 2015-02-07 23:00:07 CET

Andrzej reverted the bisected commit, marking as FIXED.

http://git.xfce.org/xfce/thunar/commit/?id=18604fad027e35d7a3f343879fc41dbf65c21e4e

Bug #11442

Reported by:
Thomas Lange

Reported on: 2015-01-10
Last modified on: 2015-02-07

People

Assignee:
Jannis Pohlmann

CC List:
2 users

Version

Version:
1.6.3

Target Milestone:
1.2.0

Attachments

Screencast which shows the issue (602.42 KB, video/ogg) 2015-01-10 17:51 CET , Thomas Lange	no flags
git-bisect.log (1.54 KB, text/plain) 2015-01-13 23:49 CET , Thomas Lange	no flags

Additional information