These two functions (_color_lighten, _color_selected):
trigger an X error:
BadValue, error_code 2 request_code 155 minor_code 8
on call to cairo_mask.
Tested on RHEL5 (AFAIR, RENDER version is 0.09) with cairo 1.12.2 installed in $HOME. All blend mode operators I tried were failing, all simple ones (CAIRO_OPERATOR_ADD etc) worked fine.
Cairo bug report:
Switches highlighting hovered icons to CAIRO_OPERATOR_ADD,
disables highlighting of selected icons.
Re-enables highlighting of selected icons via image surface fallback.
Note that this is noticeably slower when selecting multiple files via keyboard in large directories (/usr/bin).
This seems to be fixed, but we cannot find any references. Might be renderproto, using 0.11 here. Since it causes noticable performance penalties (see bug #11442), the workaround should probably be reverted or at least limited to the problematic versions (cairo/renderproto/whatever).
Can you retest/revise your commit please?
I have reverted the workaround in git.
Since there is no RENDER version checking implemented, thunar *will* crash when the Xserver's RENDER extension version is <0.11.
The proper solution is to extend version checking that already (partially)
exists in Cairo.
If anyone experiences crashes please report them in Cairo's bugzilla:
From my point of view this has been working flawlessly for quite some time already, so I presume it's fixed in Cairo. Furthermore I suggest we look into replacing all this with GtkCSS.