! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Renaming causes error message "The requested operation could not be completed"
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Jussi 2014-11-06 02:19:35 CET
Way to reproduce the problem:

1. Choose file from your desktop.
2. Open menu with right mouse button.
3. Choose rename.
4. Do not change the name or close the dialog, but wait for 15 seconds.
5. The error message appears and trash can will be disabled until you close the dialog.

xfdesktop version 4.11.8 and earlier are affected.

For more detail see:
https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/1388946
Comment 1 Eric Koegel editbugs 2014-11-09 15:03:29 CET
We're hitting DBUS's reply timeout. We'll have to find a way to perform the call without a timeout to fix this. The code in question is in:
http://git.xfce.org/xfce/xfdesktop/tree/src/xfdesktop-file-utils.c#n691
which calls xfdesktop_file_manager_proxy_rename_file_async
There's a dbus_g_proxy_call_with_timeout
http://dbus.freedesktop.org/doc/dbus-glib/dbus-glib-DBusGProxy.html#dbus-g-proxy-call-with-timeout
But the timeout is an int representing milliseconds which only gets up to 32 seconds (unless my math is off). Maybe dbus_g_proxy_call_no_reply? ...If that's not possible then we may have to not use dbus/thunar for renames and write the renaming dialog and operation ourselves to fix this issue.
Comment 2 Jussi 2014-11-09 17:15:48 CET
Maybe I haven't understand this, if so, sorry about the noise...
It seem the event is called in wrong time, is it possible call the event only after user has given new name for the file?
Comment 3 Eric Koegel editbugs 2014-11-09 17:55:47 CET
Well right now xfdesktop doesn't have code to display the rename dialog. The good news is it's not hard, it's just a matter of adding it in.
Comment 4 Thaddaeus Tintenfisch editbugs 2015-02-21 00:42:00 CET
The same applies to the "Create New Folder" and "Create New File" dialog windows.
Comment 5 Thaddaeus Tintenfisch editbugs 2015-03-28 11:31:40 CET
As of now, we simply ignore this type of error while not breaking any functionality.

http://git.xfce.org/xfce/xfdesktop/commit/?id=b0388120725ff485e5ae40fde4017aa8c7efb9cf
Comment 6 hededrk 2015-03-31 03:23:37 CEST
*** Bug 11780 has been marked as a duplicate of this bug. ***
Comment 7 Robert 2019-10-03 11:35:34 CEST
It appears this is happening again.  Can this issue be reopened, or should a new one be created?

Xubuntu 19.10
xfdesktop4 4.14.1-1
Comment 8 alexxcons editbugs 2019-10-04 22:12:18 CEST
Reopened ... I as well can reproduce the bug. Thanks for finding that old bug !
Comment 9 Robert 2019-10-05 00:15:45 CEST
You're welcome, thank you for verifying :)
Comment 10 Theo Linkspfeifer editbugs 2019-10-05 14:50:42 CEST
The change was reverted by this commit:
https://git.xfce.org/xfce/xfdesktop/commit/?id=78d841b96ce49e0427ceaa486904a529858da0bd
Comment 11 Git Bot editbugs 2019-10-06 21:59:07 CEST
Andre Miranda referenced this bugreport in commit 999cbcbaa4b9ce44815b37180da944a8347254a9

Reintroduce workaround for Bug #11283

https://git.xfce.org/xfce/xfdesktop/commit?id=999cbcbaa4b9ce44815b37180da944a8347254a9
Comment 12 Git Bot editbugs 2019-10-06 22:00:15 CEST
Andre Miranda referenced this bugreport in commit 850d3aec523467b2fe3eb22dcdbd7ff55ac3c66c

Reintroduce workaround for Bug #11283

https://git.xfce.org/xfce/xfdesktop/commit?id=850d3aec523467b2fe3eb22dcdbd7ff55ac3c66c

Bug #11283

Reported by:
Jussi
Reported on: 2014-11-06
Last modified on: 2019-10-06
Duplicates (1):
  • 11780 ‘The requested operation could not be completed’ when creating folder

People

Assignee:
Eric Koegel
CC List:
6 users

Version

Version:
4.13.5

Attachments

Additional information