! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
fullscreen app stays on top when unfocused


Description Landry Breuil editbugs 2014-09-16 21:08:13 CEST
W/ xfwm 4.11.2, probable regression from 4.10 - if i have a fullscreen app (say, terminal or ffx) in front of a non-fullscreen app and i focus the latter, focus is transmitted but the fullscreen app stays on top (and still hides the other one) instead of having it brought up to the front. Pretty sure in 4.10 this wasnt the case...

<  gaston+> hmm another potential xfwm4 regression in 4.11.. have a fullscreen app, alt-tab -> the other apps are not brought in front of the fullscreen win, only focused..
<kalikian+> gaston: does the fullscreen app stay in front whilst the focus changes to the destined app? if so I'm seeing exactly that
Comment 1 Landry Breuil editbugs 2014-09-16 21:14:30 CEST
On that matter, i have STR on a xinerama setup. have the window on top of fullscreen app, alt-tab to the fullscreen app -> the window disappears. Alt-tab to the hidden window -> doesnt come up. Focus other window on other screen with mouse, focus back the fullscreen window, focus back 'other window on other screen' - the previously hidden windowed app comes on top of fullscreen app, unfocused.
Comment 2 Landry Breuil editbugs 2014-09-18 22:32:15 CEST
just to clarify, this doesnt happen with maximized windows, only fullscreen ones.
Comment 3 Landry Breuil editbugs 2014-10-22 18:18:17 CEST
I can also confirm it's a regression - on two computers with xfwm 4.10, having a fullscreen window (be it a term or a firefox window), alt-tabbing to another window correctly brings it to the top, showing the window on top of the fullscreen one (and the xfce panel, if the said window is not fullscreen too)
Comment 4 Alistair Buxton 2014-10-22 22:33:04 CEST
Bisect revealed the regression is caused by http://git.xfce.org/xfce/xfwm4/commit/?id=7c87af29befcc91ba2e890dd822a4a69cb3263d9
Comment 5 Alistair Buxton 2014-10-22 22:55:59 CEST
Specifically this piece of code from the above commit causes the problem:

 c2 = myScreenGetClientFromWindow (screen_info, GDK_WINDOW_XID (gtk_widget_get_window ( passdata.tabwin->tabwin_list->data)), SEARCH_FRAME);
 g_message ("%p", c2);
 clientSetFocus (screen_info, c2, ev->time, NO_FOCUS_FLAG);
Comment 6 Landry Breuil editbugs 2014-10-22 22:58:28 CEST
Nick, any idea ?
Comment 7 Landry Breuil editbugs 2014-10-22 23:07:16 CEST
I can confirm that commenting out these 3 lines fixes the issue i'm seeing - will check if i get other regressions...
Comment 8 Landry Breuil editbugs 2014-10-22 23:08:50 CEST
And i also have the strange feeling it's also fixing bug 11166 while at it.. will continue using it this way to confirm.
Comment 9 Olivier Fourdan editbugs 2014-10-23 10:43:44 CEST
What bother me slightly is that it's unclear to me what the patch that introduced the regression was supposed to fix in the first place...

Comment 10 Simon Steinbeiss editbugs 2014-11-20 08:49:42 CET
*** Bug 11120 has been marked as a duplicate of this bug. ***
Comment 11 Olivier Fourdan editbugs 2014-12-28 23:31:26 CET
Should be fixed with git commit 0151f6b
Comment 12 Landry Breuil editbugs 2014-12-29 22:14:26 CET
yeah, reconfirming since that commit removes the lines i had to comment out to workaround it when i tested in comment 7.. that leaves bug 11166.

Bug #11167

Reported by:
Landry Breuil
Reported on: 2014-09-16
Last modified on: 2014-12-29
Duplicates (1):
  • 11120 xfwm4-4.11.2 does not raise window under full-screen window despite having focus


Olivier Fourdan
CC List:
10 users




Additional information