! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Not synced "Show status bar" in Preferences and View > Statusbar
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
trivial
Product:
Mousepad
Component:
General

Comments

Description Sergey 2014-07-27 10:38:43 CEST 
If Edit > Preferences > Window > "Show status bar" is checked/unchecked,
then corresponding View > Statusbar is not updated, but if View > Statusbar
is checked/unchecked, then "Show status bar" state in Preferences is
correctly updated. The same is for Preferences "Show toolbar" and View >
Toolbar.
Comment 1 Andre Miranda editbugs 2015-03-08 01:56:35 CET 
*** Bug 11616 has been marked as a duplicate of this bug. ***
Comment 2 Andre Miranda editbugs 2015-03-09 02:11:32 CET 
Still happens on 0.4.0 with GTK3.
Also for:
Toolbar / Show toolbar
Tab Size / Tab width
Line Numbers / Show line numbers
Word Wrap / Wrap long lines
Auto Indent / Enable automatic indentation
Comment 3 Theo Linkspfeifer editbugs 2019-04-24 16:48:50 CEST 
*** Bug 14047 has been marked as a duplicate of this bug. ***
Comment 4 Theo Linkspfeifer editbugs 2019-05-31 00:15:43 CEST 
Created attachment 8604 
diff

This fix does the job, but it may need to be improved code-wise.
Comment 5 Andre Miranda editbugs 2019-06-07 16:34:12 CEST 
The patch works, I'm just surprised it had to add too many lines.
The only weird thing I spotted was in 'mousepad_window_update_document_actions', 'window->active' is accessed before checking if 'window' is valid.
Comment 6 Matthew Brush editbugs 2019-06-08 02:15:34 CEST 
It does seem like a lot of code, I would've guessed it was just not binding something correctly (ie. bidirectionally or whatever).

@Theo, did we just miss a bunch of code that is present for other settings?
Comment 7 Theo Linkspfeifer editbugs 2019-06-08 10:29:51 CEST 
The patch adds the missing bindings. Initially, some of the buttons were only toggled when switching tabs.

I assume that the code can be simplified. I only expanded on what was already present.
Comment 8 Andre Miranda editbugs 2019-06-17 00:40:23 CEST 
(In reply to Theo Linkspfeifer from comment #7)
> I assume that the code can be simplified. I only expanded on what was
> already present.

I'm willing to push your patch as is, we can always improve the code later, please provide a patch with commit info if you agree.
Comment 9 Maurizio Galli 2019-07-20 20:35:44 CEST 
(In reply to Theo Linkspfeifer from comment #4)
> Created attachment 8604 
> diff
> 
> This fix does the job, but it may need to be improved code-wise.

I confirm that the patch fixes the sync issue.
Comment 10 Theo Linkspfeifer editbugs 2019-11-14 11:50:59 CET 
Created attachment 9230 
patch
Comment 11 Theo Linkspfeifer editbugs 2019-11-14 14:52:35 CET 
Created attachment 9231 
patch

Removed some unneeded spaces.
Comment 12 Git Bot editbugs 2019-12-06 05:02:00 CET 
Theo Linkspfeifer referenced this bugreport in commit ef7acc4f09631fb57300a9a7eb121b4dd0e3cd99

Sync remaining menu actions to their settings (Bug #11046)

https://git.xfce.org/apps/mousepad/commit?id=ef7acc4f09631fb57300a9a7eb121b4dd0e3cd99
Comment 13 Andre Miranda editbugs 2019-12-06 05:02:36 CET 
Thanks Theo!

Bug #11046

Reported by:
Sergey
Reported on: 2014-07-27
Last modified on: 2019-12-06
Duplicates (2):
  • 11616 Preferences menu and view menu status bar enablements aren't links
  • 14047 Mousepad - Settings from view menu aren't synchronised with settings in settings dialog

People

Assignee:
Matthew Brush
CC List:
6 users

Version

Version:
Unspecified
Target Milestone:
Mousepad 0.4.x

Attachments

diff (10.56 KB, patch)
2019-05-31 00:15 CEST , Theo Linkspfeifer 		no flags
patch (11.47 KB, patch)
2019-11-14 11:50 CET , Theo Linkspfeifer 		no flags
patch (11.45 KB, patch)
2019-11-14 14:52 CET , Theo Linkspfeifer 		no flags

Additional information