! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Installing libgtk2.0-0=2.7.4* make labels on xfce4-taskbar exceed the buttons...
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
critical
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description Vittorio Palmisano 2005-07-31 09:29:37 CEST 
Installing libgtk2.0-0=2.7.4* make labels on xfce4-taskbar exceed the buttons
dimensions.

1. install xfce4-panel=4.2.2-1, libxfcegui4-3=4.2.2-1 (from os-cillation repository)
2. install libgtk2.0-bin=2.7.4-0ubuntu1 (or version from experimental)
3. restart xfce4-panel with xfce4-taskbar-plugin

this patch should fix this bug:

--------------------------------------------------------------------------------
--- libxfcegui4-4.2.2/libxfcegui4/netk-tasklist.c       2005-05-15
09:53:29.000000000 +0200
+++ libxfcegui4-4.2.2.new/libxfcegui4/netk-tasklist.c   2005-07-31
11:11:33.000000000 +0200
@@ -2237,9 +2237,11 @@

     if (task->tasklist->priv->show_label) {
         task->label = gtk_label_new (text);
+        gtk_label_set_width_chars(task->label, 1000);
+        gtk_label_set_ellipsize(task->label, PANGO_ELLIPSIZE_END);
         gtk_widget_show (task->label);
         gtk_table_attach (GTK_TABLE (table),
-                      task->label, 1, 2, 0, 1, GTK_EXPAND, GTK_EXPAND, 0, 0);
+                      task->label, 1, 2, 0, 1, GTK_EXPAND|GTK_FILL|GTK_SHRINK,
GTK_EXPAND, 0, 0);
     }

     gtk_container_add (GTK_CONTAINER (task->button), table);
--------------------------------------------------------------------------------
Comment 1 Vittorio Palmisano 2005-07-31 09:30:41 CEST 
Created attachment 280 
Patch proposed
Comment 2 Jasper Huijsmans editbugs 2005-07-31 09:51:53 CEST 
That only works for gtk >= 2.6. IIRC, xfce 4.2.2 still supports gtk 2.2. I hate
it when gtk devs change the behaviour of widgets :(

We probably should add it with #ifdef's around it.
Comment 3 Vittorio Palmisano 2005-07-31 14:21:59 CEST 
Created attachment 281 
Patch proposed

added gtk version check
Comment 4 andrei perhinschi 2005-08-23 14:39:00 CEST 
*** Bug 1124 has been marked as a duplicate of this bug. ***
Comment 5 Jean-François Wauthy editbugs 2005-08-27 16:11:48 CEST 
*** Bug 1131 has been marked as a duplicate of this bug. ***
Comment 6 Jasper Huijsmans editbugs 2005-08-28 07:50:59 CEST 
(In reply to comment #3)
> Created an attachment (id=281) [edit]
> Patch proposed
> 
> added gtk version check

Hey Vittorio,

Sorry for not responding earlier. I noticed that you removed the ellipsize call
from the second patch. In that case I don't think there is a problem with
earlier gtk versions. I added it to SVN trunk (without the check) and it works
well in gtk 2.8.2. 

The ellipsize might still be a nice feature for gtk 2.6 and higher, so I'll keep
the report open for now. 

Also, I should add the fix to the 4.2 branch after I check that it does indeed
work for gtk 2.4.

Thanks a lot for the patches!
Comment 7 Olivier Fourdan editbugs 2005-10-10 16:44:38 CEST 
This is already done in SVN, why do we need that patch at all ?
Comment 8 Brian J. Tarricone (not reading bugmail) 2005-10-15 11:25:51 CEST 
Is this fixed on 4.2 branch also?
Comment 9 Olivier Fourdan editbugs 2005-10-15 11:48:44 CEST 
Yes, of course.
Comment 10 Brian J. Tarricone (not reading bugmail) 2005-10-15 12:08:50 CEST 
Then let's close it ^_^
Comment 11 Olivier Fourdan editbugs 2005-11-05 15:23:30 CET 
*** Bug 1210 has been marked as a duplicate of this bug. ***
Comment 12 Jean-François Wauthy editbugs 2005-11-09 19:42:35 CET 
*** Bug 1212 has been marked as a duplicate of this bug. ***
Comment 13 Brian J. Tarricone (not reading bugmail) 2006-01-06 01:48:14 CET 
*** Bug 1310 has been marked as a duplicate of this bug. ***
Comment 14 Brian J. Tarricone (not reading bugmail) 2006-01-16 09:52:35 CET 
*** Bug 1331 has been marked as a duplicate of this bug. ***

Bug #1099

Reported by:
Vittorio Palmisano
Reported on: 2005-07-31
Last modified on: 2009-07-14
Duplicates (6):
  • 1124 taskbar text messed up with pango 1.10.0
  • 1131 the text is span over to the place of the next tab
  • 1210 Text overflows on taskbar.
  • 1212 Long Window names "spill out" and obscure other windows
  • 1310 Long text in taskbar entries is not truncated, but instead spills out (sporadic)
  • 1331 taskbar shows overlapping captions for application icon

People

Assignee:
Nick Schermer
CC List:
6 users

Version

Version:
4.2.x
Target Milestone:
Panel Old

Attachments

Patch proposed (749 bytes, patch)
2005-07-31 09:30 CEST , Vittorio Palmisano 		no flags
Patch proposed (802 bytes, patch)
2005-07-31 14:21 CEST , Vittorio Palmisano 		no flags

Additional information