10636 – Reverting a file claims to fail, even though it worked.

Reverting a file claims to fail, even though it worked.

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Mousepad

Component:

General

Comments

Description Alistair Buxton 2014-01-16 15:50:58 CET

To reproduce:

1. Open some file.
2. Modify it.
3. File->Revert.

A dialog is displayed: "Failed to reload the file." but the file is reloaded anyway.

Comment 1 Andre Miranda editbugs

2014-09-05 23:21:45 CEST

*** Bug 11133 has been marked as a duplicate of this bug. ***

Comment 2 Andre Miranda editbugs

2014-09-06 00:29:25 CEST

Created attachment 5629 
Patch

The attached patch solves the problem.
Apparently the return from mousepad_file_open was misinterpreted, 0 is success but when casted to boolean it yields false.

Comment 3 Alistair Buxton 2014-09-24 22:40:09 CEST

ACK. Trivial patch. Should be merged immediately :)

Comment 4 Landry Breuil editbugs

2015-02-28 13:55:06 CET

Applied right before releasing 0.4.0, thanks!

Comment 5 Tony Newman 2017-06-05 10:29:44 CEST

*** Bug 13621 has been marked as a duplicate of this bug. ***

Bug #10636

Reported by:
Alistair Buxton

Reported on: 2014-01-16
Last modified on: 2017-06-05

Duplicates (2):

11133 Incorrect error message during revert
13621 Menu item 'Revert' works, but complains that it didn't.

People

Assignee:
Matthew Brush

CC List:
6 users

Version

Version:
0.3.0

Target Milestone:
Mousepad 0.2.x

Attachments

Patch (961 bytes, patch)
2014-09-06 00:29 CEST , Andre Miranda

andreldm : review? ( matt )

Additional information