! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Announce xfce4-panel requests as coming from a Pager
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description Arnout Engelen 2013-11-23 22:38:03 CET
Some window managers (such as notion) treat Pager applications slightly differently from normal clients.

The XFCE4 panel is a pager, and can announce itself as such by calling 'wnck_set_client_type' on startup*. 

This will make it work better on window managers like notion.

(not tested, as it seems the latest git depends on garcon-gtk2-1 which does not appear to be available on Debian yet)
Comment 1 Arnout Engelen 2013-11-25 13:06:45 CET
Built garcon and made the change, I can confirm it has the desired result.

Get it from git at https://github.com/raboof/xfce4-panel
Comment 2 Nick Schermer editbugs 2013-11-30 17:27:24 CET
Problem is that wnck start to throw errors the 2nd time the value is set, so with 2 pagers this would be a problem. Now the tasklist and everything else should than technically also set this, but then the errors get even worse.
Comment 3 Arnout Engelen 2013-12-01 23:29:21 CET
You're right of course. 

What would be the proper place to do this? It would make sense to do it early on on startup (after all, the panel *is* a pager). On the other hand, right now only the plugins depend on wnck, the main code does not.

Would you be opposed to have a dependency on wnck from the main code? Where should the source indication be set?
Comment 5 Nick Schermer editbugs 2013-12-26 18:33:09 CET
Pushed in d296ca7.
Comment 6 Hans-Peter Deifel 2014-01-22 18:10:37 CET
*** Bug 9520 has been marked as a duplicate of this bug. ***
Comment 7 Landry Breuil editbugs 2014-12-10 11:20:26 CET
Seems this bug caused regressions, see bug 11055 and its dupe 10747
Comment 8 Olivier Fourdan editbugs 2014-12-10 22:41:12 CET
Fix is correct, closing.

Bug #10508

Reported by:
Arnout Engelen
Reported on: 2013-11-23
Last modified on: 2014-12-10
Duplicates (1):
  • 9520 tasklist plugin doesn't set wnck client type

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
4.10.1

Attachments

Additional information