! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"Show hidden files" doesn't work
Status:
RESOLVED: DUPLICATE

Comments

Description Hezy Amiel 2009-03-22 00:21:11 CET
In the preferences menu there is an option to "Show hidden files". However this as no effect at all, even after pressing the "Refresh" button. as a result there is no way to burn hidden files or folders.

This bug was tested on xfburn 0.3.2
Comment 1 Jorge Zuanon 2009-04-13 14:52:41 CEST
I don't know how to create a patch, this is how I "fix" it. 

//-----------------------------------------------------------------
// file: "xfburn/trunk/xfburn/xfburn-utils.c", line: 64

gboolean
xfburn_hidden_files(const gchar *temp)
{
  if(temp != '.')
    return TRUE;
  else
    return xfburn_settings_get_boolean("show-hidden-files",TRUE);
}



//-----------------------------------------------------------------
// file: "xfburn/trunk/xfburn/xfburn-utils.h", line: 35

gboolean xfburn_hidden_files(const gchar *);



//-----------------------------------------------------------------
// file: "xfburn/trunk/xfburn/xfburn-fs-browser.c", line: 155/156

if (xfburn_hidden_files(dir_entry[0]) && g_file_test (full_path, G_FILE_TEST_IS_DIR) &&
        !g_file_test (full_path, G_FILE_TEST_IS_SYMLINK)) {



//-----------------------------------------------------------------
// file: "xfburn/trunk/xfburn/xfburn-directory-browser.c", line: 269

if (xfburn_hidden_files(dir_entry[0]) && (stat (full_path, &s) == 0)) {


//-----------------------------------------------------------------


The refresh button, doesn't refresh the fs browser, so if the settings change, only in the directory browse (after clicking refresh) will show or hide the hidden files/folders.

(revision 7175)

Jorge Zuanon
Comment 2 David Mohr 2009-04-22 16:57:30 CEST
Thanks for the info Jorge. Creating a patch is quite easy, specially if you work from svn. Just create the changes in the checked out directory, and then run 'svn diff'. That would be more useful, otherwise this will have to wait a bit, since I'm pretty busy at the moment.
Comment 3 Jorge Zuanon 2009-04-22 18:55:20 CEST
Created attachment 2312 
Show hidden files

Hi David, here is the patch.
Comment 4 David Mohr 2009-07-09 22:52:35 CEST
Thanks again for the patch, and sorry it took so long. I implemented it a bit differently, let me know if you still have trouble.

*** This bug has been marked as a duplicate of bug 5500 ***

Bug #5135

Reported by:
Hezy Amiel
Reported on: 2009-03-22
Last modified on: 2009-07-09

People

Assignee:
Xfburn Bug Triage
CC List:
2 users

Version

Attachments

Show hidden files (1.99 KB, patch)
2009-04-22 18:55 CEST , Jorge Zuanon
no flags

Additional information