! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add a preference to remove prompting when deleting an image
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Ristretto
Component:
Application

Comments

Description Louis Casillas 2013-04-11 05:11:17 CEST
Created attachment 4996 
File Deletion Prompt Preference Patch

I have found it frustrating to continually be prompted during image deletion so I created a patch that adds a preference to turn off image deletion prompting.  It adds the preference in the Behavior tab under the section 'File Deletion'.  The default behavior is still to prompt the user while deleting images.

The patch effects the files:
- main_window.c
- preferences_dialog.c
- settings.c

The patch adds two strings:
- "File Deletion"
- "Prompt during file deletion"

As of now the patch should work smoothly with the current master git repository with:
> patch -p1 -i ristretto-file-deletion-prompt.patch

I am not sure what tools you're using to update the .po files so I did not attempt to add all necessary .po changes to the patch.  I also did not change the NEWS file.

Feel free to contact me if there are any issues.

-Louis Casillas
E-mail: oxaric@gmail.com
Comment 1 Michael Werle 2014-02-14 00:08:22 CET
Created attachment 5360 
Patch to make the delete confirmation dialog optional.

Great minds think alike.. wish I'd've seen this bugzilla before breaking out gvim. Considering I've written it now, may as well share.

My patch does pretty much the same thing as Louis's, but also removes the duplicated code between "delete" and "trash".
Comment 2 Landry Breuil editbugs 2015-02-19 10:31:34 CET
*** Bug 11405 has been marked as a duplicate of this bug. ***
Comment 3 Mathias Brodala 2015-02-20 22:43:28 CET
Adding my remark from #11405:

For permanent deletion (Shift+Del) the dialog makes sense since it is basically an irreversible action. But there is no need to confirm moving files to the trash from which they can be restored anytime.
Comment 4 IMTheNachoMan 2018-08-07 05:46:55 CEST
Hello. I was told this patch will not apply properly. More information at https://forum.xfce.org/viewtopic.php?pid=49205#p49205.

Any way I could get a patch that will work with Ubuntu 18.04.1?

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"


$ uname -a
Linux desk 4.15.0-29-generic #31-Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ ristretto -V
ristretto 0.8.2
Comment 5 Git Bot editbugs 2020-05-25 00:29:37 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/ristretto/-/issues/8.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #9989

Reported by:
Louis Casillas
Reported on: 2013-04-11
Last modified on: 2020-05-25
Duplicates (1):
  • 11405 Remove confirmation for moving files to trash

People

Assignee:
Stephan Arts
CC List:
3 users

Version

Version:
master

Attachments

File Deletion Prompt Preference Patch (8.42 KB, application/octet-stream)
2013-04-11 05:11 CEST , Louis Casillas
no flags
Patch to make the delete confirmation dialog optional. (12.57 KB, patch)
2014-02-14 00:08 CET , Michael Werle
no flags

Additional information