With: http://cgit.freedesktop.org/upower/commit/?id=9843589d2d80e6dc2b3f51338e64bd1da1c53860 upower is deprecating suspend/hibernate interface. http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html Calls to upower should switch to logind. http://www.freedesktop.org/wiki/Software/systemd/logind kde implented this in: https://git.reviewboard.kde.org/r/108407/diff/#index_header
Created attachment 4994 Add-systemd-logind-support-for-suspend-hibernate.patch Patch for systemd-logind support is attached.
Works fine here. Thanks!
Created attachment 5196 systemd suspend/hibernate support xfce4-session treats "challenge" responses as true, the attached version of the patch does the same here for consistency
What's the status on those patches, especially compared to: https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/xfce4-power-manager-systemd-inhibit.patch?expand=1 https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/xfce4-power-manager-systemd-shutdown-reboot-support.patch?expand=1 https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/xfce4-power-manager-systemd-suspend-hibernate-suport.patch?expand=1 ?
(In reply to Yves-Alexis Perez from comment #4) > What's the status on those patches, especially compared to: > > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > xfce4-power-manager-systemd-inhibit.patch?expand=1 > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > xfce4-power-manager-systemd-shutdown-reboot-support.patch?expand=1 > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > xfce4-power-manager-systemd-suspend-hibernate-suport.patch?expand=1 > > ? What do you mean by status, the three patches do different things and they are attached to their respective bugs here on bugzilla.xfce.org. https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/xfce4-power-manager-systemd-suspend-hibernate-suport.patch?expand=1 is the patch that I attached to comment #3.
(In reply to Guido Berhoerster from comment #5) > (In reply to Yves-Alexis Perez from comment #4) > > What's the status on those patches, especially compared to: > > > > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > > xfce4-power-manager-systemd-inhibit.patch?expand=1 > > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > > xfce4-power-manager-systemd-shutdown-reboot-support.patch?expand=1 > > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > > xfce4-power-manager-systemd-suspend-hibernate-suport.patch?expand=1 > > > > ? > > What do you mean by status, the three patches do different things and they > are attached to their respective bugs here on bugzilla.xfce.org. > https://build.opensuse.org/package/view_file/X11:xfce/xfce4-power-manager/ > xfce4-power-manager-systemd-suspend-hibernate-suport.patch?expand=1 is the > patch that I attached to comment #3. I found bug #9335 for the inhibit patch and bug #10167 for the shutdown/reboot. Is that correct? By status, I mean I'm not sure what's the latest version I should use (for the Debian packages). It seems the one on this bug was updated yesterday, not sure if the other need an update etc? Also, I'm adding Nick to CC: since Aliov is completely MIA these days, so maybe he can comment on the patches and commit them if they look sane.
(In reply to Yves-Alexis Perez from comment #6) > I found bug #9335 for the inhibit patch and bug #10167 for the > shutdown/reboot. Is that correct? Correct, see also bug #9952 for the corresponding xfce4-session patch. > By status, I mean I'm not sure what's the latest version I should use (for > the Debian packages). It seems the one on this bug was updated yesterday, > not sure if the other need an update etc? The patch on bug #9952 should be fine. > Also, I'm adding Nick to CC: since Aliov is completely MIA these days, so > maybe he can comment on the patches and commit them if they look sane. IMO systemd support should be detected at runtime like in xfce4-session rather than a compile-time option. What will Debian/Ubuntu do when upower drops suspend/hibernate?
(In reply to Guido Berhoerster from comment #7) > (In reply to Yves-Alexis Perez from comment #6) > > I found bug #9335 for the inhibit patch and bug #10167 for the > > shutdown/reboot. Is that correct? > > Correct, see also bug #9952 for the corresponding xfce4-session patch. > > > By status, I mean I'm not sure what's the latest version I should use (for > > the Debian packages). It seems the one on this bug was updated yesterday, > > not sure if the other need an update etc? > > The patch on bug #9952 should be fine. Thanks. > > > Also, I'm adding Nick to CC: since Aliov is completely MIA these days, so > > maybe he can comment on the patches and commit them if they look sane. > > IMO systemd support should be detected at runtime like in xfce4-session > rather than a compile-time option. What will Debian/Ubuntu do when upower > drops suspend/hibernate? Well, right now, it seems we'll lose suspend/hibernate support in Xfce, unfortunately…
Created attachment 5428 Add support for logind suspend/hibernate (runtime checks) This patch does runtime checks to see if we can use logind for suspend/resume same as poweroff/reboot. It will continue to work fine without it.
Pushed to master in: http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=6cdc97e979b6924913ce270b06ad92d304e61ee4