Created attachment 4973 The patches The attached patch set is compile tested only. I've looked it over carefully and think it should be "ok" I was unable to run it because the latest src from git crashes on my machine. If someone knows of a stable commit to test from, I'd be happy to run it on my machine to test. Thanks! Greg
Thanks for the patches. The first one looks fine, but I'm a bit unsure about the second; A better solution might be to check for the old and new strings on reading and always write the new, corrected string. I have yet to decide whether to apply it at all, depending on the other changes that go into the next version. Latest git works fine here, so to be able to help you I'd need more info. What's the problem specifically?
First patch pushed with modifications in http://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=27e3d937d5d97b69ff47ccd096503115a386232e.
Hi Harald, Thanks for accepting my patch! This is my first contribution to xfce and also building parts of xfce from source. Some general info about how I'm building the weather plugin and my system. Ubuntu quantal; ran apt-get install xubuntu-desktop and installed a bunch of development dependencies xfce version 4.10 on a 64 bit AMD kernel i was able to get the plugin to run and crash last night... but today I can't get it to even show up in the "Add New Items" dialog. Here's an example of what I just tried: sudo apt-get purge xfce4-weather- plugin git clone git://git.xfce.org/panel-plugins/xfce4-weather-plugin ./autogen.sh ./configure --prefix=/usr make sudo make install If you'd like me to roll a patch that better handles the settings, I am willing to do that. But as you can see, proper testing is difficult at the moment.
There's nothing wrong with the way you try to build the plugin and your problems are very likely distribution-specific, so please ask for help at the appropriate xubuntu forums or mailing lists. If you get it up and running but it still crashes on runtime, the README file has some simple instructions for debugging. No new patch for the config settings is required, it's merely I have not decided yet what to do about it. Thanks for your contribution, I will close this bug now.