! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
current time improvements
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Liv 2013-03-18 13:26:02 CET
I notice some issues with the current time displayed in underneath the current location. First, the time display is sometimes jerky and increments in two-second steps. 

But also would it be possible to have a date formatting that indicates current weekday? For example: 
liv@liv-laptop:~$ date +%c
Mon 18 Mar 2013 01:09:22 PM CET

or: 
liv@liv-laptop:~$ date +"%A, %d %B %Y %X (%Z)"
Monday, 18 March 2013 01:25:15 PM (CET)

Having the weekday indicate will allow to quickly relate 'Today' in the first line of forecasting with a concrete weekday (monday).
Comment 1 Harald Judt 2013-03-18 14:29:51 CET
Created attachment 4972 
delay-update-a-bit.patch

That issue is a bit weird. Maybe that timeout stuff isn't that exact and happens too early. Please try this patch and report whether it fixes the problem or at least improves the situation. Actually adding only 1 helped on my laptop and I therefore thought it was an off-by-one issue, but maybe that was not the case and other machines behave differently.
Comment 2 Liv 2013-03-19 23:31:12 CET
Although it's tough to replicate this issue, it seeems that the patch helps and the current time display is much less jerky than before.
Comment 3 Harald Judt 2013-03-19 23:56:17 CET
Hm, only less jerky? I believe this is a problem with updating the title and scheduling the next update at a detrimental moment, though I do not understand it exactly and honestly, I believe it might be a bit tricky to get it right. Adding 10ms seemed to be the simplest working solution for whatever reason, but it's certainly not perfect. Other solutions I tried were slightly more complicated and did not even work that well.

Let's bluntly assume your laptop a difficult case and try to use 25 instead of 10 in the patch. If 10 did not help, maybe 25 will. Most living human beings will probably not be able to recognize a 25ms delay ;-) That's the sleeping time for the scrollbox animation BTW. I know it sounds a bit like a joke, but can you try this and report back? If it doesn't help, I'll need to look for a better solution.

  update_interval = 1000 - (now_ms % 1000) + 10; <-- change 10 to 25

As for reproducing: In my case, I could reproduce it by hovering over a forecast cell to generate a tooltip, albeit not with the 10ms patch. The clock would then skip 1 second sometimes.
Comment 4 Liv 2013-03-20 08:23:29 CET
Oh, sorry! By less jerky I actually meant that with the first patch I was noticing no jerkiness at all. It's difficult to confirm, but it seems to me that it does the trick.
Comment 5 Harald Judt 2013-03-21 14:43:50 CET
I've pushed the patch in http://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=72fdfaec8c9b4c65af6ec9123d7ef910df755f99. Thanks for reporting.

As for a custom format, I do not want to implement that because it means adding more options and changing the format for occurrences in other parts of the plugin. ISO 8601 is standard, and besides that you can quickly relate the particular weekday by looking two lines further below or to the right.

If you're looking for a code change, you can edit the format in the source file weather-summary.c in function update_summary_subtitle(), "man strftime" tells you the proper conversion parameters, which may be a bit different from "date".

Bug #9933

Reported by:
Liv
Reported on: 2013-03-18
Last modified on: 2013-03-21

People

Assignee:
Harald Judt
CC List:
1 user

Version

Attachments

delay-update-a-bit.patch (797 bytes, patch)
2013-03-18 14:29 CET , Harald Judt
no flags

Additional information