! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Edge is too close when border-radius = 0
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-notifyd
Component:
general

Comments

Description Dinkel 2013-02-25 22:42:28 CET
Created attachment 4938 
Screenshot edge padding

When setting the border-radius to 0, the padding between the edge of the notification and the text is quite small and this looks a little ugly to me.

See attached screenshot (top part).

The problem is, that the padding is calculated based on the border-radius option and adding 4 pixels.

Attached you will also find a patch against "master" that remedies this problem by introducing another option named "padding" which can be set in the gtkrc file like so:

style "notify-window"
{
    XfceNotifyWindow::border-color = "#ffffff"
    XfceNotifyWindow::border-radius = 0.0
    XfceNotifyWindow::border-width = 2.0
    XfceNotifyWindow::padding = 10.0   // THIS IS THE NEW OPTION
    bg[NORMAL] = "#242424"
}

See attached screenshot (bottom part).

I was trying to use GTK's built-in functionality to get the same look (using style properties), but failed. I don't know if its just me or if its not possible to do ...

The themes in this repository should not be affected by this patch as they are using the default border-radius 10. I've set the default value for the padding to be 14 (10 + 4) if not explicietely set.

Btw: I just found out, that my last patch (#9475) also introduced a local variable named "padding". I hope this is not too confusing ;-).
Comment 1 Dinkel 2013-02-25 22:43:30 CET
Created attachment 4939 
Patch for configurable content padding
Comment 2 Jérôme Guelfucci editbugs 2013-03-16 18:57:47 CET
Pushed to git master branch, thanks a lot for your contribution.

Bug #9876

Reported by:
Dinkel
Reported on: 2013-02-25
Last modified on: 2013-03-16

People

Assignee:
Jérôme Guelfucci
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information