! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Desktop background does not cycle when "change the background" selected
Status:
RESOLVED: DUPLICATE
Product:
Xfdesktop
Component:
General

Comments

Description Mark Wagner 2013-02-24 00:44:57 CET
Created attachment 4934 
patch against 4.10.0 that fixes the bug

When "change the background" is selected in the "Desktop" control panel, the background changes once, after the specified interval, and then stops changing.

The cause of the problem is that the timer callback, xfce_backdrop_timer() in xfce-backdrop.c, does not return "TRUE" to indicate that it should continue to be called periodically.  Instead, it returns void, and the calling function interprets whatever happens to be on the stack at the function return value address as a boolean.

I've attached a patch against 4.10.0 that fixes this issue.
Comment 1 Jérôme Guelfucci editbugs 2013-03-02 17:46:00 CET
Thank you for your bug report. It has already been fixed in the git master branch and will soon be fixed in a stable release.

*** This bug has been marked as a duplicate of bug 8962 ***

Bug #9873

Reported by:
Mark Wagner
Reported on: 2013-02-24
Last modified on: 2013-03-02

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
4.10.0

Attachments

patch against 4.10.0 that fixes the bug (807 bytes, application/octet-stream)
2013-02-24 00:44 CET , Mark Wagner
no flags

Additional information