! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Length limit of interface names precludes use of valid interfaces


Description Patrick O'Keeffe 2013-02-22 08:39:08 CET
In the properties dialog of the Network Monitor plugin, the Network device field has a 10-character limit. This makes it unusable with valid network interfaces with names greater than 10 characters. Yes, long-named interfaces exist: one example is the 'easytether0' interface created when tethering an Android phone using EasyTether. 

This applies to xfce4-netload-plugin 1.1.0-1 which is the Latest Version according to Synaptic Package Manager. (Not listed in choices so I left 'unspecified')
Comment 1 Raphael Groner 2013-02-22 12:26:47 CET
The fix seems to be easy. Look here:


But I guess, there is a reason why the name is limited in length. I can see code to calculate the visual size of the plugin.
Comment 2 Patrick O'Keeffe 2013-02-27 05:04:42 CET
Created attachment 4941 
patch for bug 9869
Comment 3 Patrick O'Keeffe 2013-02-27 05:05:56 CET
This patch increases the field width of the device name from 10 to 20 characters. The other text entry fields' lengths are unaffected (though logically separated).

I could not find the code related to calculating plugin visual size. I'm guessing it won't matter though because the entry fields for 'max value' also relied on the same MAX_LENGTH constant despite being of narrower width.
Comment 4 Mike Massonnet editbugs 2014-11-02 13:47:32 CET
git commit 215438c9e674b642cc757b2c1ec04700c8a1141a
Comment 5 poma 2014-11-10 17:03:02 CET
(In reply to Mike Massonnet from comment #4)
> git commit 215438c9e674b642cc757b2c1ec04700c8a1141a

Mike, here only hager's patch really works.

Predictable Network Interface Names cannot fit - xfce4-netload-plugin-1.2.2
Comment 6 Kevin Fenzi 2014-11-21 21:02:12 CET
(In reply to Mike Massonnet from comment #4)
> git commit 215438c9e674b642cc757b2c1ec04700c8a1141a

Hey Mike. Can you please take a look at this again? The above fix doesn't seem to do the job... ;(
Comment 7 Mike Massonnet editbugs 2014-11-22 17:47:22 CET
looking into this now
Comment 8 Mike Massonnet editbugs 2014-11-22 18:08:29 CET
reverted previous commit:
git commit fbda085f4ed1435c873bce8a70c11d06da63060a

new commit to restrict iface length to 32 chars:
git commit 18e253fc227c279fe2bdfd7e520bf17d23af9dfb
Comment 9 Mike Massonnet editbugs 2014-11-22 18:12:21 CET
git commit bc8b2eee5101f990df522339d141b711d614ba67

extra char for \0
Comment 10 Mike Massonnet editbugs 2014-11-22 18:40:23 CET
for the records, linux iface names are limited to 16 chars (including \0)
Comment 11 Kevin Fenzi 2014-11-22 23:03:22 CET
Thanks for the quick fix!
Comment 12 poma 2014-11-24 19:54:44 CET
Thanks guys.
Comment 13 Skunnyk editbugs 2020-05-21 01:22:05 CEST
*** Bug 9807 has been marked as a duplicate of this bug. ***

Bug #9869

Reported by:
Patrick O'Keeffe
Reported on: 2013-02-22
Last modified on: 2020-05-21
Duplicates (1):
  • 9807 Netload-plugin cannot handle predictable interface names.


Florian Rivoal
CC List:
7 users




patch for bug 9869 (2.05 KB, patch)
2013-02-27 05:04 CET , Patrick O'Keeffe
no flags

Additional information