! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[BASIC PATCH] Add filter entry to search especific command lines.
Status:
RESOLVED: FIXED
Product:
Xfce4-taskmanager
Component:
General

Comments

Description Matias De lellis 2013-02-14 21:58:45 CET
Created attachment 4914 
Add filter entry to search especific command lines.

Hi,
99% of the time, just use the taskmanager to control the memory usage of the applications development

Summit this patch, but is basic due try to be the least intrusive as possible. eg missing connect the icon to clear the search (8 lines of code), and not change the dialog, so the GtkEntry is below (only need to open glade).

Well,
If you are interested, and I'm following the rules of code style, complete the patch.

Regards,
Matias
Comment 1 Matias De lellis 2013-02-14 23:09:55 CET
Created attachment 4915 
Add filter entry to search especific command lines. V2
Comment 2 Matias De lellis 2013-02-18 16:00:33 CET
p.s: Patch V2 fix all.
* Fix warning when taskmanager inform a closed process.
* Put the entry directly in glade file and move it above.
* Connect secundary icon to clean entry.
Comment 3 Landry Breuil editbugs 2014-12-01 09:29:41 CET
A minor nit while looking at this:

process-window.c: In function 'filter_entry_keyrelease_handler':
process-window.c:94: warning: control reaches end of non-void function


filter_entry_keyrelease_handler is declared as returning a gboolean but returns nothing.
Comment 4 Landry Breuil editbugs 2014-12-01 09:56:02 CET
Nice feature, merged in 9ca4c078, fixed filter_entry_keyrelease_handler() to return has_text in ff69f4d3 and fixed indentation in e1e8ceb7
Comment 5 Matias De lellis 2014-12-01 21:00:08 CET
Hi Landry,

Thank you for making you responsible for the program!. =)

> filter_entry_keyrelease_handler is declared as returning a gboolean but returns nothing.
> fixed filter_entry_keyrelease_handler() to return has_text

NOO: It was a mistake, but due something else.. The "changed" signal must be return void!!!

https://developer.gnome.org/gtk2/stable/GtkEditable.html#GtkEditable-changed

Sorry, I could not see it before. :S

Regards,
Comment 6 Landry Breuil editbugs 2014-12-03 09:17:08 CET
Right, refixed in 66c00f18

Bug #9856

Reported by:
Matias De lellis
Reported on: 2013-02-14
Last modified on: 2014-12-03

People

Assignee:
Mike Massonnet
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information