! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar crashes when going Back to non-exisitng directory
Status:
RESOLVED: FIXED

Comments

Description Miro Hrončok 2013-02-04 20:32:17 CET
Description of problem:
When gong Back in Thunar, but the directory in history doesn't exist anymore, Thunar crashes.

Version:
1.6.2 (not in the list here)

How reproducible:
Always.

Steps to Reproduce:
1. Create a directory, let's say ~/testdir
2. Navigate Thunar to that directory
3. Go up in directory structure (in example case to ~)
4. Either rename or delete ~/testdir
5. Go back in history (use toolbar icon or hit [Backspace])
  
Actual results:
Thunar crashes

Expected results:
Thunar raises error saying the directory in history no longer exists and asks the user if he wants to go directly to last existing directory in history. The error dialog provides a checkbox to prevent this dialog to show again next time.

Or simply perform the action above without any dialog.
Comment 1 Øyvind Ingvaldsen 2013-02-07 22:02:40 CET
Created attachment 4903 
Fixes segfault on history not found in Thunar

This simple patch will avoid the segfault happening when a location in history is not found. 

After applying the patch, Thunar will simply show an error message "Could not find <folder>".

There is still one small "bug" in this scenario though: the back button will have the graphic of being pressed down until you navigate to another folder. I can look into it.
Comment 2 Miro Hrončok 2013-04-21 23:31:06 CEST
(Didn't test the patch yet).

Just noticed: When you press the "go up" button (to go to a non-existing directory), the error is shown. But when you press "go back" button (to go to a non-existing directory), this crash occur. One code may probably be used to handle both cases.
Comment 3 Nick Schermer editbugs 2013-04-29 19:09:34 CEST
Pushed in 6829079.
Comment 4 Nick Schermer editbugs 2013-05-01 17:01:48 CEST
*** Bug 9805 has been marked as a duplicate of this bug. ***

Bug #9831

Reported by:
Miro Hrončok
Reported on: 2013-02-04
Last modified on: 2013-05-01
Duplicates (1):
  • 9805 Thunar crashes when path that now open in it renamed in another program

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

Fixes segfault on history not found in Thunar (454 bytes, patch)
2013-02-07 22:02 CET , Øyvind Ingvaldsen
no flags

Additional information