! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
'close' item in embed c-menu
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-embed-plugin
Component:
General

Comments

Description Liv 2013-01-18 14:15:26 CET
xfce4-embed 1.2.0
Xfce 4.10
Xubuntu 12.04 Precise

Please add a 'close' item in the Embed Plugin context menu. 

Currently I use Embed with IMAP Notify and because of a bug in that app I need to restart it rather frequently. At the moment restarting an embedded app is not trivial: pop-out, close, start, embed. The plugin allowed to close an app via its c-menu, then (it seems to me) restarting would be as simple as: close, start.
Comment 1 David Schneider 2013-01-19 10:37:02 CET
Seems like IMAP notify needs to be fixed :)

Are you proposing that the close menu item would disable embedding until explicitly restarted, or would it immediately attempt to resume embedding after closing?  Seems like a reasonable feature, but the semantics are a bit ambiguous.

Alternatively, if you have xfce4-embed-plugin set up to launch IMAP Notify, you could create a launcher button next to it that runs "pkill -f imapnotify.py" or something similar.  Then xfce4-embed-plugin will immediately re-launch and re-embed IMAP Notify.  One button!
Comment 2 Liv 2013-01-19 11:22:47 CET
(In reply to comment #1)
> Seems like IMAP notify needs to be fixed :)
> 
Yes, but it works for the author so he lost interest in further maintaining it. :)


> Are you proposing that the close menu item would disable embedding until
> explicitly restarted, 
No.

> or would it immediately attempt to resume embedding
> after closing?  Seems like a reasonable feature, but the semantics are a bit
> ambiguous.
> 
Yes, this is what I had in mind: Closing the app and re-starting it manually would make Embed embed it immediately. 


> Alternatively, if you have xfce4-embed-plugin set up to launch IMAP Notify,
> you could create a launcher button next to it that runs "pkill -f
> imapnotify.py" or something similar.  Then xfce4-embed-plugin will
> immediately re-launch and re-embed IMAP Notify.  One button!
>
At the expense of another button on the panel (which in my case is overcrowded). But having 'Close' item in the c-menu seems reasonable to me, since in Embed the window loses WM buttons, and 'Close' is one button that users would want to have.
Comment 3 David Schneider 2013-01-19 12:06:03 CET
Reasonable indeed.  I'll look into it.
Comment 4 David Schneider 2013-01-26 21:08:21 CET
I've added the feature; it's in git now.  Please try it out and see if it does what you'd expect.

I have it set such that if you didn't specify a launch command, it will immediately attempt to embed a new window.  If you DID specify a launch command, it will behave like a manual "pop-out", and will not attempt to launch and embed a window until you say "embed" again (which you can do by simply double-clicking).

I also reorganized the menu items a little.
Comment 5 Liv 2013-01-29 18:49:01 CET
I've tested latest GIT and the new feature seems to work exactly as I expected. Thanks!

Bug #9778

Reported by:
Liv
Reported on: 2013-01-18
Last modified on: 2013-02-03

People

Assignee:
David Schneider
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information