! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Autogenerated menu only includes the last [Desktop Action] entry from *.desktop
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Erik Harrison 2005-05-17 03:00:39 CEST
I decided to try this autopackage thing out. It works much like Benny's
installers do. However, the gaim.autopackage I used includes a modified .desktop
file. This .desktop file includes not only the Gaim entry, but menu entries for
verifying and removing the gaim package. Only the "Remove Package" option
appeared in the autogenerated system menu. Upon playing with the file, I could
make the Gaim entry appear by removing the "Remove" and "Verify" [Desktop
Action] entries from gaim.desktop

A quick perusal of the spec shows this to be a valid, if apparently rare,
configuration, as show at
http://standards.freedesktop.org/desktop-entry-spec/latest/apa.html

Reproducible: Always
Steps to Reproduce:
1. 
2. 
3.
Comment 1 Erik Harrison 2005-05-17 03:01:23 CEST
Created attachment 237 
The gaim.desktop file causing the problem
Comment 2 Brian J. Tarricone (not reading bugmail) 2005-05-17 18:06:15 CEST
That example attached to the spec is weird: if you read through the spec, they
only define the "Desktop Entry" group, and then say you can add your own groups
using the "X-PRODUCT" notation to show it's non-standard.  But then the example
.desktop file doesn't do that.  Weird.

Anyway, there *is* a slight bug here; it looks like Benny's .desktop parser
doesn't check for group names.  Unfortunately the code is somewhat non-obvious,
so I'll have to look at it again later.

Note that I have no intention of trying to support anything but stuff in the
"Desktop Entry" group, as the names for other non-standard groups are free-form
and app authors can use them for basically anything, with no way of clearly
defining their purpose.
Comment 3 Erik Harrison 2005-05-17 18:50:41 CEST
Perhaps I oughtta drop a bug on both the standard and autopackage then. 

The essential problem is that additional entries block Gaim from showing up in the menu. I presume 
that fixing the group names bug would resolve that.
Comment 4 Brian J. Tarricone (not reading bugmail) 2005-05-18 00:29:04 CEST
(In reply to comment #3)
> Perhaps I oughtta drop a bug on both the standard and autopackage then. 

Or at least bug them (fd.o) to be clearer about what's allowed regarding extra
groups in the file.

> The essential problem is that additional entries block Gaim from showing up in
the menu. I presume 
> that fixing the group names bug would resolve that.

Yep.  After I figure out how =p.
Comment 5 Brian J. Tarricone (not reading bugmail) 2005-06-16 19:59:29 CEST
Hey Benny - when I last looked at the XfceDesktopEntry class, it looks like it
isn't checking only in the "[Desktop Entry]" group, and it's picking up lines
from other groups if they appear in the .desktop file after the main group.  It
wasn't exactly obvious to me how to fix this - could you provide some insight?
Comment 6 Brian J. Tarricone (not reading bugmail) 2005-10-15 11:19:58 CEST
Should be fixed in SVN.  Please test, since I didn't.  Just realised this is
Jasper's code, not Benny's =p

Bug #970

Reported by:
Erik Harrison
Reported on: 2005-05-17
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

The gaim.desktop file causing the problem (2.23 KB, text/plain)
2005-05-17 03:01 CEST , Erik Harrison
no flags

Additional information