! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
When using an Image as an icon (.xpm), XFCE does not resize in the popup menu
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Libxfce4panel

Comments

Description James Bellinger 2012-12-09 17:36:02 CET
Created attachment 4787 
the icon I ran into this with

When I click the mouse logo and navigate to Development, the icon (created using an Image) is much too large instead of being properly resized. I encountered this with the icon .xpm included with the Android Developer Toolkit's version of Eclipse.

It's properly resized in the dialog editing the menu item, but the popup menu itself keeps it enormous, resulting in only being able to see 'oolkit' for text 'Android Developer Toolkit'.

By the way, sometimes this only happens after mouse-over. Not sure why.
Comment 1 Carlos Silva 2012-12-14 02:19:30 CET
Created attachment 4794 
Fix-icons-not-probably-resizing-when-requested.patch

Hi, I just stumbled with this problem and found this bug. As I like to solve stuff myself I'll attach the patch that fixes this problem.

I explained the change on the patch, so any questions I can try to answer them here.
Comment 2 Andrzej editbugs 2013-01-12 12:11:13 CET
Pushed in:
48e1016 Fix icons not probably resizing when requested.
Comment 3 Lionel Le Folgoc 2013-01-12 20:32:38 CET
*** Bug 9221 has been marked as a duplicate of this bug. ***
Comment 4 mikkl 2013-01-14 23:13:04 CET
Created attachment 4854 
workaround the broken scaling of icons from gdk_pixbuf_new_from_file_at_scale()

The right click menu which is a component of xfdesktop also suffers from this problem. I have taken Carlos Silva's patch and the scaling bits from the  xfce_panel_pixbuf_from_source_at_size() function to create a workaround for xfdesktop as well.
Comment 5 Olivier Duchateau 2013-03-14 19:32:32 CET
(In reply to comment #4)
> Created attachment 4854 
> workaround the broken scaling of icons from
> gdk_pixbuf_new_from_file_at_scale()
> 
> The right click menu which is a component of xfdesktop also suffers from
> this problem. I have taken Carlos Silva's patch and the scaling bits from
> the  xfce_panel_pixbuf_from_source_at_size() function to create a workaround
> for xfdesktop as well.

With gdk-pixbuf2-2.26.5, and xfdesktop 4.10.2, patch (src/xfdesktop-app-menu-item.c) for seems not work. XPM icons disappear.
Comment 6 Simon Steinbeiss editbugs 2015-02-19 13:37:10 CET
Since the original patch is pushed and the last two comments tackle xfdesktop (separate component, separate bugreport), I'm marking this as fixed.

Bug #9615

Reported by:
James Bellinger
Reported on: 2012-12-09
Last modified on: 2015-02-19
Duplicates (1):
  • 9221 XPM icons in the menu are not scaled

People

Assignee:
Nick Schermer
CC List:
7 users

Version

Version:
4.10.0

Attachments

Additional information