! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] GtkSpell support in Mousepad


Description Daichi Kawahata 2005-05-14 15:09:35 CEST
I've enabled spell check support with GtkSpell/Aspell, it's simplest
addition in code-wise, if there're more demands I'd like to try more.
Note that I'm not programmer, any kind of. I'm definitely welcome your
modifying, developers.

Reproducible: Always
Steps to Reproduce:

Due to absence of off-switch, entered texts would be checked on-the-fly.
Comment 1 Daichi Kawahata 2005-05-14 15:10:57 CEST
Created attachment 230 
this patch enables spell checking with gtkspell
Comment 2 Daichi Kawahata 2005-05-14 15:14:15 CEST
Created attachment 231 
mousepad with on-the-fly spell checking

I don't know whether there's copyright issue in the image,
if so point me out.
Comment 3 Erik Harrison 2005-08-23 22:54:26 CEST
I've decided that GtkSpell support isn't going to go in, for various reasons.

I may reconsider it for the future
Comment 4 Erik Harrison 2007-01-15 19:52:38 CET
Reopening this bug as part of renewed 4.5/4.6 related work on Mousepad
Comment 5 Erik Harrison 2007-01-24 23:38:43 CET
Created attachment 965 
From Maximilian Schleiss and Nick Shermer

This is a new patch by Max Schleiss modified from work by Nick Shermer that applies to current mousepad tree
Comment 6 Robby Workman editbugs 2008-06-09 18:52:42 CEST
Poke... if memory serves correctly, mailing list discussions led to this being a WONTFIX... ?

(yes, I'm just surveying the bug list looking for any obvious ones that can be addressed)
Comment 7 Erik Harrison 2008-06-09 21:36:12 CEST
It's Nick's call now, and the jury is still out.
Comment 8 rff1917 2009-10-16 11:15:15 CEST
This would be a very nice feature. Are you considering committing the patch?
Comment 9 Andre Miranda editbugs 2013-11-06 17:56:04 CET
I vote for this feature because Mousepad is a general purpose editor in my view, I mean it's not a fully featured code editor nor a writting application.
Some users that like to write some notes or drafts could benefit from spell check.
If this feature represents new dependency(ies), a configure option could be used.
Comment 10 Tamaranch 2020-04-24 19:37:30 CEST
Any news on this?
I also think it would be a great feature!
Just like Andre Miranda said: "Some users that like to write some notes or drafts could benefit from spell check."
I'm one of them!
Comment 11 Andre Miranda editbugs 2020-04-25 21:32:55 CEST
Created attachment 9799 

Proof of concept using gspell, see FIXME comment on why it's not possible to change language or get suggestions. It's also missing a menu option to toggle spell checking.

Don't expect me to finish this implementation, anyone is more than welcome to pick up from where I left.
Comment 12 Tamaranch 2020-05-08 18:02:16 CEST
Created attachment 9845 
Adding gspell

I made some progress to add gspell to Mousepad, but I don't know if the way I retrieve the gspell menu is acceptable.

It does not correspond to what Andre Miranda had in mind, I guess: I tried to keep gspell as a black box, and I played with the populate-popup signal to retrieve the gspell menu (see mousepad_window_menu_textview_shown()).

I tried also to not slow Mousepad as much as possible, in particular at startup, because gspell initialization has a significant cost.

For the menu option that toggle spell checking, I simply made a copy of what exists for other features, like automatic indentation or word wrap.
Comment 13 Matthew Brush editbugs 2020-05-09 01:57:32 CEST
It would be great to get libpeas or own home-rolled plugin system integrated into Mousepad so that extensions like this could be added without bloating up the main program. I've done some work on this in the past but never got it finished/working completely. That's not to say I'm against adding gtk/gspell support into Mousepad for now, but there are lots of little things like this that eventually add up to a lot of extra code/complexity and which are not needed by many users.

Maybe I will try to revive my efforts with libpeas soon-ish.
Comment 14 Tamaranch 2020-05-11 11:27:16 CEST
Created attachment 9852 

Change author in case of commit
Comment 15 Tamaranch 2020-05-21 17:44:05 CEST
Created attachment 9883 

Simplify the way to subtract the gspell menu, avoid possible regressions (e.g. from https://git.xfce.org/apps/mousepad/commit/?id=f70c88b0e35a9ea2120f145374f1bb7600c52ca0).
Comment 16 Tamaranch 2020-05-21 18:48:24 CEST
Created attachment 9884 

Small fixup.
Comment 17 Tamaranch 2020-05-21 19:40:55 CEST
Created attachment 9885 

The last one (at least for today), I hope!
Comment 18 Git Bot editbugs 2020-05-24 01:26:39 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/mousepad/-/issues/1.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #957

Reported by:
Daichi Kawahata
Reported on: 2005-05-14
Last modified on: 2020-05-24


Matthew Brush
CC List:
6 users




this patch enables spell checking with gtkspell (2.27 KB, patch)
2005-05-14 15:10 CEST , Daichi Kawahata
no flags
mousepad with on-the-fly spell checking (20.68 KB, image/png)
2005-05-14 15:14 CEST , Daichi Kawahata
no flags
From Maximilian Schleiss and Nick Shermer (8.22 KB, patch)
2007-01-24 23:38 CET , Erik Harrison
no flags
gspell.diff (5.18 KB, patch)
2020-04-25 21:32 CEST , Andre Miranda
no flags
Adding gspell (23.60 KB, patch)
2020-05-08 18:02 CEST , Tamaranch
no flags
0001-Add-gspell.patch (23.59 KB, patch)
2020-05-11 11:27 CEST , Tamaranch
no flags
0001-Add-gspell.patch (24.10 KB, patch)
2020-05-21 17:44 CEST , Tamaranch
no flags
0001-Add-gspell.patch (24.30 KB, patch)
2020-05-21 18:48 CEST , Tamaranch
no flags
0001-Add-gspell.patch (24.34 KB, patch)
2020-05-21 19:40 CEST , Tamaranch
no flags

Additional information