! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfconf-4.10.0 fails to pass `make check` because of po/POTFILES.in or .skip i...
Status:
RESOLVED: FIXED
Severity:
trivial

Comments

Description Samuli Suominen 2012-11-28 10:29:39 CET
After verifying from git[1] I noticed that this bug[2] is still not fixed.

[1] http://git.xfce.org/xfce/xfconf/tree/po/POTFILES.in
[2] http://bugs.gentoo.org/show_bug.cgi?id=444996

Unfortunately this is fatal instead of plain warning:

Making check in po
make[1]: Entering directory `/var/tmp/portage/xfce-base/xfconf-4.10.0/work/xfconf-4.10.0/po'
XGETTEXT_ARGS="--keyword=Q_ --from-code=UTF-8" INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext --keyword=Q_ --from-code=UTF-8" srcdir=. /usr/bin/intltool-update --gettext-package xfconf --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

xfconf-perl/xs/Xfconf.c
xfconf-perl/xs/XfconfBinding.c
xfconf-perl/xs/XfconfChannel.c

If some of these files are left out on purpose then please add them to
POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list
of left out files has been written in the current directory.
Please report to http://bugzilla.xfce.org/
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[1]: *** [check] Error 1

The most simplest solution I can think of, if these files don't have any translatable strings is to add file po/POTFILES.skip with content of:

xfconf-perl/xs/Xfconf.c
xfconf-perl/xs/XfconfBinding.c
xfconf-perl/xs/XfconfChannel.c

Thank you!
Comment 1 Eric Koegel editbugs 2014-07-06 13:25:12 CEST
Created attachment 5540 
Add files to POTFILES.skip

This fixes the build issue by adding those files to POTFILES.skip.
Comment 2 Jannis Pohlmann editbugs 2014-07-25 13:32:22 CEST
Fix (for make check at least) pushed to master:

commit 71dc20b5197391adaf7a4253f6b7cb6c767db3ad
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Fri Jul 25 12:56:45 2014 +0200

    Fix make check when including perl bindings in the build (bug #9556)
    
    Comment from Jannis: Unfortunately, make distcheck remains broken as the
    xfconf-perl Makefile.PL does not properly track where the generated
    files are installed, resulting in "make uninstall" to leave these files
    behind in the system.

Bug #9556

Reported by:
Samuli Suominen
Reported on: 2012-11-28
Last modified on: 2014-07-25

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
2 users

Version

Version:
4.10.0

Attachments

Add files to POTFILES.skip (655 bytes, patch)
2014-07-06 13:25 CEST , Eric Koegel
no flags

Additional information