! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Urgency blinking does not raise panels with autohide enabled.
Status:
RESOLVED: MOVED
Severity:
trivial
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description Fedor Sinev 2012-11-25 04:16:14 CET
Created attachment 4755 
Fixes a bug where panels with autohide would not raise when a window had an urgency hint

The issue:
When the urgency blinking status is enabled on windows, the component does not automatically raise or open the XFCE panel from its hidden state.

The fix:
To fix this, I've created a patch which prevents the panel from autohiding and raises it by calling the panel's plugin interface to block autohide while the blinking state is activated.

According to Nick Schermer on #xfce-dev, if I'm interpreting this correctly, a cleaner and internal way could be done to correct this problem such as using events and signaling or even raising the panel in libxfce4panel's `xfce_arrow_button_set_blinking` call, but there's certain concerns it might break plugin compatibility.

Anyways, I'm not sure what the best course of action is, but it works and only depends on the plugin. If anyone is opposed to this patch or its mechanism, naturally, please comment.

Rationale:
In Windows, an urgency notification of a window would automatically raise your panel or "taskbar." I feel if some one is running tasklist (Windows Buttons), they are expecting similar behavior.

How to test for this bug:
1. Enter the "Panel Preferences" interface.
2. Under Display, make sure "Automatically show and hide the panel" is checked.
3. Use an application to send you an urgency hint (e.g: Skype chat, nickname highlighting in XChat, or just send yourself a message on any IRC server by typing in /msg {NICK} message and then rapidly unfocus the window)
4. Raise the panel by moving the mouse to the very bottom
5. If you see an urgency hint and your panel has not been raised automatically, you have experienced this bug.
Comment 1 Fedor Sinev 2012-11-25 13:09:59 CET
Unfortunately, I forgot to take into account that blocking autohide is global and that triggering button flashing is individual when patching this. Like Nick noted, if there's more than one window requesting attention and I focus on it, tasklist unhides it.

This should be relatively easy to fix though and I'll get to it later this day.
Comment 2 Git Bot editbugs 2020-05-28 01:44:17 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/48.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #9543

Reported by:
Fedor Sinev
Reported on: 2012-11-25
Last modified on: 2020-05-28

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information