9485 – Filename sorting is incorrect for some cases

Filename sorting is incorrect for some cases

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Ristretto

Component:

Application

Comments

Description rmlipman 2012-11-10 11:26:44 CET

Created attachment 4723 
1265256043721.png

A simple case I could find where this fails:

Place both attached images in a new folder
Open 1265256043721.png in Ristretto
Switch to filename sorting

What should happen:
1265256043721.png should be the first image because it comes before 1329396810786.jpg alphabetically


What actually happens:
1265256043721.png is the second image even though it should come first alphabetically

Comment 1 rmlipman 2012-11-10 11:27:03 CET

Created attachment 4724 
1329396810786.jpg

Comment 2 Eric Koegel editbugs

2012-12-21 07:37:41 CET

Created attachment 4807 
Fixed an overflow when comparing filenames with large  numbers in them

Proposed patch should fix an overflow when comparing filenames with large numbers in them.

Comment 3 rmlipman 2013-01-02 04:05:52 CET

I tested this patch on a bigger folder of files with large numbers in them and it worked for me.

Comment 4 Stephan Arts editbugs

2013-01-06 17:19:36 CET

Thanks Eric, I've applied the patch to ristretto 0.3.x, 0.6.x and master.

Bug #9485

Reported by:
rmlipman

Reported on: 2012-11-10
Last modified on: 2013-01-06

People

Assignee:
Stephan Arts

CC List:
0 users

Version

Version:
master

Target Milestone:
---

Attachments

1265256043721.png (1.21 MB, image/png) 2012-11-10 11:26 CET , rmlipman	no flags
1329396810786.jpg (117.80 KB, image/jpeg) 2012-11-10 11:27 CET , rmlipman	no flags
Fixed an overflow when comparing filenames with large numbers in them (1.71 KB, patch) 2012-12-21 07:37 CET , Eric Koegel	no flags

Additional information