! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shouldn't unref the return value of g_file_icon_get_file ()?
Status:
RESOLVED: FIXED

Comments

Description Lionel Le Folgoc 2012-11-01 17:49:43 CET
Created attachment 4704 
Possible patch?

Hi,

It seems that g_file_icon_get_file () is annoted "transfer none" (cf. <http://developer.gnome.org/gio/2.32/GFileIcon.html#g-file-icon-get-file>), and I think this means that the return value isn't owned by the caller, so shouldn't be unref'd?

It is fine in thunar/thunar-file.c (not unref'd), but in thunar/thunar-notify.c it is unref'd (same issue in xfdesktop, because src/xfdesktop-notify.c is a copy of this file).

Thanks.
Comment 1 Nick Schermer editbugs 2012-11-01 18:10:24 CET
Fixed.

Bug #9439

Reported by:
Lionel Le Folgoc
Reported on: 2012-11-01
Last modified on: 2012-11-01

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

Possible patch? (552 bytes, patch)
2012-11-01 17:49 CET , Lionel Le Folgoc
no flags

Additional information