! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-power-manager 1.2.0 does not compile on GNU/Hurd


Description Pino Toscano 2012-10-28 22:59:12 CET
Created attachment 4700 
Build fix on GNU/Hurd

The compilation of xfce4-power-manager 1.2.0 fails on GNU/Hurd, because of the following two includes not available:
- sys/sysctl.h
- sys/user.h

They have been added with rev 8a30a7b [1] (bug #8712), and according to the bug they were moved from a linux-only block to a non-specific one because they were needed for FreeBSD. Given that it seems they are not needed on Linux (sysctl() is not used on Linux blocks in that file), and removing them causes no build failure on Linux, my suggestion is to include them only on FreeBSD, just below <sys/stat.h>.
Attached there is a patch (compilation tested only on Linux and Hurd, not on FreeBSD though) for it.

[1] 8a30a7b29b19df5a7700124625624a2e6243b39b
Comment 1 Eric Koegel editbugs 2014-06-01 14:35:12 CEST
Pushed a commit that should fix this issue for you: http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=af69bc562f1f7dbc8f94e246779beb7a8bb45904
Let us know if this fixes it for you and feel free to report if have any more issues with GNU/Hurd (or any kernel + userland :)
Comment 2 Eric Koegel editbugs 2014-07-16 19:42:59 CEST
Marking resolved.

Bug #9423

Reported by:
Pino Toscano
Reported on: 2012-10-28
Last modified on: 2014-07-16


Ali Abdallah
CC List:
1 user



Build fix on GNU/Hurd (429 bytes, patch)
2012-10-28 22:59 CET , Pino Toscano
no flags

Additional information