In commit, 9c64229317f83c67186a65cc0c271cc5d28cebac - "weather-http: Fix compilation with C99." it says Let's hope this doesn't break anything else... It breaks compilation on Solaris. Both in normal and C99 modes, addrinfo and friends end up being undefined. weather-http.c: In function `weather_http_receive_data_idle': weather-http.c:155: error: storage size of 'h' isn't known weather-http.c:195: warning: implicit declaration of function `getaddrinfo' weather-http.c:207: warning: implicit declaration of function `gai_strerror' Reverting the commit to the version shipped in 0.8.1 works just fine. (Generally, adding these #defines in application code is an error; the compiler should enable/disable the appropriate standards automatically.)
(In reply to comment #0) > (Generally, adding these #defines in application code is an error; the > compiler should enable/disable the appropriate standards automatically.) Apparently the automagic doesn't work here, so one would need to provide additional parameters like -D_POSIX_SOURCE etc. I agree the current state is messy and I'd like to get rid of it, but I guess I will have to study GNU automake to be able to solve this. Do you have any suggestions where and what to look for?
While this error has not been fixed, it should have disappeared with http://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=94d75c2a08a05c485cae127741717387f25c2d2e.