! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Icon's issues.
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Masato Hashimoto 2012-08-26 12:13:46 CEST
Base design of CLOUD.png and CLOUD-night.png are different.(CLOUD.png should be used on both, shouldn't it)

LIGHTRAINSUN and -night, LIGHTRAINTHUNDER and -night, SNOWSUN and -night are slightly different.
I think, these are not problem but it will be found easily when each icons are appeared at the same time.

Though I don't confirm source or behavior, the following weathers miss night icons??
SLEETSUN, SLEETSUNTHUNDER, SNOWTHUNDER, SNOWSUNTHUNDER
Comment 1 Harald Judt 2012-08-27 14:53:55 CEST
> Base design of CLOUD.png and CLOUD-night.png are different. (CLOUD.png should
> be used on both, shouldn't it)

I've used CLOUD-night because it has been available when I started development, but the icon theme is not very consistent, that's true. I will use only CLOUD.png, because if it's that cloudy, then neither moon nor sun will be seen, same as with RAIN.

> LIGHTRAINSUN and -night, LIGHTRAINTHUNDER and -night, SNOWSUN and -night
> are slightly different.

I'm not sure, perhaps this is intentional? One would have to try what looks better: Change moon icons to look like sun icons, change sun icons to look like moon icons or leave them as they are now.

> Though I don't confirm source or behavior, the following weathers miss night
> icons?? SLEETSUN, SLEETSUNTHUNDER, SNOWTHUNDER, SNOWSUNTHUNDER

Yes, these are clearly missing.

One problem here is that I don't know where that "liquid" theme is from. You can find different themes with that name on the Web, but not exactly the same as the weather plugin uses. I've looked around a bit, but then gave up due to lack of time.

However, because the different icons are composed from the same elements, it is rather easy to create new icons. I will look into it or perhaps ask Simon Steinbeiß to produce some nice-looking icons, he did good work before and has more experience with gimp than I do.

Thanks for reporting.
Comment 2 Harald Judt 2012-08-29 13:19:20 CEST
This should be fixed in http://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=5102cd261ff1f995a73960e869d6085ac16c81ac.

I've made the moon icons look similar to the sun icons. I'm still not really satisfied with the moon which is hard to distinguish on dark panels, but these problems can be solved when there is better theming support, and I don't want to modify the existing theme too much.

If you can spare some time, please look for possible mistakes, all those similar icons and names might have fooled me ;-)

Bug #9242

Reported by:
Masato Hashimoto
Reported on: 2012-08-26
Last modified on: 2012-08-30

People

Assignee:
Harald Judt
CC List:
1 user

Version

Attachments

Additional information