! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Sometimes desktop icons are messed up.
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description vaxon77 2012-08-10 00:46:36 CEST
Created attachment 4586 
desktop configuration

I have only one 1920x1200 dislplay connected and only one .config/xfce4/desktop/icons.screen0-1904x1118.rc file.

I have all default icons (home, filesystem, trash, removable devices' enabled in my desktop. Automount is disabled.

Sometimes after reboot the default icons get messed up. Sometimes trash icon is not displayed at all.

I'm not sure, probably auto-generation of the device icons messes it up.
I have a couple of 32GB partitions on my hard drive, which icons are named exactly the same on the Desktop - "[32 GB Volume]". However, there's only one such entry in the icons.screen0-1904x1118.rc.
Sometimes one of the [32 GB Vilume] icons appears in the top left corner instead of [Home] while [Home] is placed lower where the [2.2 GB Volume] should be. The other block device icons are messed up as well.

This is kind of annoying, since my block device configuration doesn't change. and there are no removable devices attached.

Even if the block device icons are re-generated each time, it should not affect the position of other icons. I expect all icons to take their places as configured in the previous session, while new device icons should be placed at free desktop areas.

Thanks,
Val.
Comment 1 Thomas Haenig 2012-11-22 09:50:20 CET
I don't think it has something to do with "autogenerated icons" because I do not have such (everything related to removable media is disabled) but the behaviour seems the same - sometimes after reboot most of the Icons are messed up and appear in several packed rows from top left of the desktop (without empty positions). Only one of the default icons of the desktop is enabled here, its trash.

The last manual change of icons positions (adding one, moving another, ...) is way back, so the question is, when/why gets this file touched and which process would do it?


System is OpenSuSE 12.2 64bit, XFCE 4.10

Display is 1280x1024, icon positions file is named icons.screen0-1264x971.rc
Comment 2 Eric Koegel editbugs 2013-02-25 14:26:39 CET
Created attachment 4937 
More consistent icon placement

The proposed patch should fix some issues with icon placement.
Specifically when the screen size changes, icons are loaded from 
the icon cache if the position is available, then an attempt is
made to re-locate the icon at its original position before the
change event, if that is still available, and finally any leftover
icons are appended to any free position. This should help keep the
icons where the user would like them to be.
Comment 3 lpasquale 2013-06-14 15:52:22 CEST
I haven't tested the proposed patch, so I can't tell wether it actually solves the problem, but are there any chances it will be ever included in the master?
Comment 4 Eric Koegel editbugs 2013-09-15 09:39:31 CEST
Created attachment 5151 
Rework how icons are saved

This patch saves the icons based on the file's path rather than the icon name, except for volume icons where it attempts to use the volume's UUID. It applies against master but won't apply cleanly against 4.10.2 because of other changes. Let me know if this works and if there's any regressions.
Comment 5 Eric Koegel editbugs 2013-09-19 19:31:51 CEST
Pushed to master for more testing: http://git.xfce.org/xfce/xfdesktop/commit/?id=c014cb3231259ea4ffc4477f7ce7c7531f1c5d12
Comment 6 Eric Koegel editbugs 2014-03-01 17:20:50 CET
Marking resolved.

Bug #9192

Reported by:
vaxon77
Reported on: 2012-08-10
Last modified on: 2014-03-01

People

Assignee:
Eric Koegel
CC List:
8 users

Version

Version:
4.10.0

Attachments

desktop configuration (1.55 KB, text/xml)
2012-08-10 00:46 CEST , vaxon77
no flags
More consistent icon placement (9.66 KB, patch)
2013-02-25 14:26 CET , Eric Koegel
no flags
Rework how icons are saved (17.00 KB, patch)
2013-09-15 09:39 CEST , Eric Koegel
no flags

Additional information