! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Forecast window partially unreadable with dark themes
Status:
CLOSED: FIXED
Severity:
enhancement
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Dumitru Moldovan editbugs 2012-07-23 13:14:48 CEST
Created attachment 4561 
Partially unreadable forecast

In the forecast window of the xfce4-weather-plugin, the color of the background for the forecasted data for today, the day after tomorrow etc., is changed to light gray without changing the color for the foreground writing. This makes that  data unreadable in dark themes which use light grays for the foreground writing.

Please see the attached screenshot for an illustration. This seems to be a different problem then the one reported in bug #7488 as there is no problem with the label in the panel in my case, as seen in the screenshot. 

Many thanks for maintaining this useful plugin.
Comment 1 Harald Judt 2012-07-23 13:54:46 CEST
The values for the background are hardcoded.

I will try to address this in the next update.
Comment 2 Dumitru Moldovan editbugs 2012-07-23 14:35:03 CEST
A workaround would be to hardcode the color of the text too. But I'm wondering if it's possible to use the colors from the GTK+ theme to create that alternance, eg. take a look at how such an alternance looks in Evolution with my theme. I'll upload a screenshot shortly.
Comment 3 Dumitru Moldovan editbugs 2012-07-23 14:35:45 CEST
Created attachment 4562 
Example of native alternance in Evolution
Comment 4 Harald Judt 2012-07-26 21:27:30 CEST
I decided for the easy fix, setting the text color to black on alternate cells. That seems to go well with most of the themes I tried and I didn't have to rewrite too much of the code. Perhaps I try it the evolution way at a later time, but it's not just the rows, one has to care about the table headers too.

http://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=edf26ee19cb84979d4728dadaa2d735073eb3efe
Comment 5 Dumitru Moldovan editbugs 2012-07-28 22:09:24 CEST
Thank you, this seems enough. I'll double-check it with my theme when you'll increment the current version. If you plan on removing hard-coded colors, I am rooting for you.
Comment 6 Dumitru Moldovan editbugs 2012-08-06 14:20:57 CEST
I've just installed 0.8.1 and the forecast windows looks great now with my theme. Thank you!

Bug #9150

Reported by:
Dumitru Moldovan
Reported on: 2012-07-23
Last modified on: 2012-08-06

People

Assignee:
Harald Judt
CC List:
1 user

Version

Attachments

Partially unreadable forecast (168.21 KB, image/png)
2012-07-23 13:14 CEST , Dumitru Moldovan
no flags
Example of native alternance in Evolution (106.58 KB, image/png)
2012-07-23 14:35 CEST , Dumitru Moldovan
no flags

Additional information