! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"Replace" playlist stops music
Status:
RESOLVED: FIXED

Comments

Description Mike Massonnet editbugs 2012-07-10 14:02:38 CEST
(For tracking purposes only)

When selecting "Replace" in the DBBrowser, the music is stopped. Instead it should automatically start to play if the player was previously playing, or for easiness always start to play after a Replace action.
Comment 1 n0-0ne+xfce 2019-02-04 22:00:15 CET
Created attachment 8283 
Patch for starting playback after replacing the queue

The fix seemed a bit obvious so I'm not sure if I completely missed anything here. Anyways, the attached patch simply starts playback after the queue has been replaced.
Comment 2 Andre Miranda editbugs 2019-02-09 20:46:49 CET
The patch seems to work, it doesn't check if there was a music playing, as Mike described.
If you think this condition makes sense, please resend the patch (with commit info).
Comment 3 n0-0ne+xfce 2019-02-09 23:21:06 CET
Created attachment 8287 
Revised version of patch that only starts playback when MPD was playing befpre
Comment 4 n0-0ne+xfce 2019-02-09 23:22:24 CET
Ah, yes, good call. I misinterpretated "replace" as "replace and play". I updated the patch and generated it with git format-patch this time so that it should be easy to apply.
Comment 5 Andre Miranda editbugs 2019-02-10 21:55:55 CET
Merged, thanks!

Bug #9100

Reported by:
Mike Massonnet
Reported on: 2012-07-10
Last modified on: 2019-05-02

People

Assignee:
Vincent Legout
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information