! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Notes : When edit the title, the last letter not committed.
Status:
CLOSED: WONTFIX
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Kim Seongcheol 2005-04-14 01:00:47 CEST
Because I'm not good at english and programming,
So I attatch the screenshot. And it'll say all.


And this bug seems to have something to do with these, i guess.
http://bugzilla.gnome.org/show_bug.cgi?id=62948
http://bugzilla.gnome.org/show_bug.cgi?id=90082
Comment 1 Kim Seongcheol 2005-04-14 01:04:52 CEST
Created attachment 212 
An aminated gif captured from notes ver. 0.10.0
Comment 2 Choe Hwanjin 2005-04-14 12:45:33 CEST
GtkEntry has "activate" signal which will be emitted when user press return key.
I think this problem can be solved by connecting to "activate" signal instead of 
"key-press-event".

I made a patch, but I did not test it :)
See below:

--- notes.c.orig        2005-04-14 21:40:45.000000000 +0900
+++ notes.c     2005-04-14 21:42:52.000000000 +0900
@@ -82,14 +82,10 @@
     return;
 }

-gboolean
-on_title_key_press(GtkWidget *widget, GdkEventKey *event, gpointer data)
+void
+on_title_activate(GtkWidget *widget, gpointer data)
 {
-    if (event->type == GDK_KEY_PRESS) {
-       if ((event->keyval == GDK_Return) || (event->keyval == GDK_KP_Enter)) {
-           on_title_change_done((Note *)data);
-       }
-    }
+    on_title_change_done((Note *)data);
     return FALSE;
 }

@@ -272,8 +268,8 @@
     /* when double-clicked the title becomes visible, send Note as data */
     g_signal_connect(G_OBJECT(event_box), "button_press_event",
                     G_CALLBACK(on_title_change), (gpointer)note);
-    g_signal_connect(G_OBJECT(title), "key-press-event",
-                    G_CALLBACK(on_title_key_press), (gpointer)note);
+    g_signal_connect(G_OBJECT(title), "activate",
+                    G_CALLBACK(on_title_activate), (gpointer)note);

     g_signal_connect(G_OBJECT(text_view), "focus-in-event",
                     G_CALLBACK(on_text_view_focus_in), (gpointer)note);
Comment 3 Kim Seongcheol 2005-04-14 22:42:13 CEST
Hwanjin, it works.
Thanks.
Comment 4 Nick Schermer editbugs 2007-01-09 19:11:06 CET
Ancient bug, probably fixed a long time ago... Please reopen if you have this problem with the notes plugin from trunk.

Bug #910

Reported by:
Kim Seongcheol
Reported on: 2005-04-14
Last modified on: 2009-07-15

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information