! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Single non-square icon incorrectly aligned in systray
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Notification Area

Comments

Description Max 2012-07-07 09:49:10 CEST
Overview:
If systray contains only single one non-square icon (width > height) the icon has wrong position so the only top half of icon is visible (icon shifted to the bottom). 
The y coordinate is 13 instead of 2 (show frame is 'on'). But when systray contains more icons then position correct.
Panel row size is 24, maximum icon size in plugin settings is 22 (default values). 

Steps to Reproduce:
1) make sure systray contains no icons (unload all programs which add icons to systray and/or add indicator plugin to the panel if necessary)
2) start program which add non-square icon to systray (I've tried sbxkb http://sourceforge.net/projects/staybox/files/sbxkb-0.7.6.tar.gz/download , xxkb http://sourceforge.net/projects/xxkb/files/latest/download with rectangular icons and simple python example http://stackoverflow.com/a/4416367)

Actual Results:
Icon vertical y position is 13 so the only top half of the icon is visible (see screenshot 'non-squared-icon-position.png' attached).

Expected Results:
Icon should be vertically aligned to the middle of systray.

Build Date & Platform:
Reproducible every time on Xubuntu 12.04 with Xfce 4.10 (I have tried ppa xubuntu-dev, building from tarballs and building from git repository).

Additional Information:
Square icons are not affected.
Comment 1 Max 2012-07-07 10:00:44 CEST
Can't attach any files, bugzilla says 'The file you are trying to attach is empty, does not exist, or you don't have permission to read it.' but its not true.
Comment 2 Max 2012-07-07 10:07:40 CEST
Created attachment 4544 
Panel log file, contains coordinates.
Comment 3 Max 2012-07-07 10:09:54 CEST
Created attachment 4545 
Python simple gtk statusicon test (I used 21x14 image)
Comment 4 Max 2012-07-07 10:11:00 CEST
Created attachment 4546 
Proposed patch
Comment 5 Git Bot editbugs 2017-06-21 23:51:12 CEST
Max referenced this bugreport in commit 4ab55dd6baed42d8b4440a786fa5d28394721f30

systray: Fix alignment of single non-square items (Bug #9095)

https://git.xfce.org/xfce/xfce4-panel/commit?id=4ab55dd6baed42d8b4440a786fa5d28394721f30
Comment 6 Simon Steinbeiss editbugs 2017-06-21 23:51:54 CEST
Sorry it took so long for anyone to reproduce and test this (even though you attached everything needed for that).

Done and fixed!

Bug #9095

Reported by:
Max
Reported on: 2012-07-07
Last modified on: 2017-06-21

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
4.13.0

Attachments

Additional information