! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Add margin toggle option
Status:
CLOSED: DUPLICATE
Severity:
enhancement
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Miguel Guedes 2012-07-02 09:57:54 CEST
Created attachment 4535 
Patch: add margin toggle option

Allow panel margin to be toggled when progress bars are in use so as to make better use of usable height and to also integrate better with sensors plugin (see included screenshot.)


http://www.zimagez.com/zimage/screenshot-020712-085419.php
Comment 1 Miguel Guedes 2012-07-02 09:59:34 CEST
Screenshot of patched options dialog: http://www.zimagez.com/zimage/screenshot-020712-085901.php
Comment 2 Miguel Guedes 2012-07-02 10:08:20 CEST
Attached new patch containing PT Po/Br (European Portuguese and Brazilian Portuguese) translation string: "Show margin".
Comment 3 Miguel Guedes 2012-07-02 10:08:58 CEST
Created attachment 4536 
Add PT Po/Br translation string "Show margin"
Comment 4 Miguel Guedes 2012-07-02 10:48:31 CEST
Created attachment 4537 
FIXED: Patch: add margin toggle option

Patch #4535 contains duplicate code found in bug id 9073 (https://bugzilla.xfce.org/attachment.cgi?bugid=9073) which means it won't apply correctly IF it is applied after the patch found in bug 9073.

This new, fixed, patch depends on the bug described at the URL above (bug #9073) being first patched. Correct sequence is then: fix bug 9073, then apply this patch.
Comment 5 Landry Breuil editbugs 2012-07-02 17:18:35 CEST
We have HIG for panel plugins now, and i'm not sure adding an option to remove the margin/plugin border fits with it. See https://wiki.xfce.org/dev/hig/panel-plugins#widgets_paddingsize
Comment 6 Miguel Guedes 2012-07-02 18:46:17 CEST
Ok, Landry, thanks for that: makes sense and it's good to know there is a standard as far as HI is concerned. 

What are you guys planning/have planned regarding the sensors and CPU Graph plugins? These plugins provide an option for toggling margins, hence why I went ahead and added the same feature to netload.

Sample here: http://www.zimagez.com/zimage/screenshot-020712-174310.php
Comment 7 Landry Breuil editbugs 2012-07-02 19:15:43 CEST
As for cpugraph i was wondering if i should just remove the option but since it's here ppl might be used to it and would complain if the option is removed. And for sensors plugin, you'll have to ask its maintainer but i'm pretty sure it must be fixed to better respect the HIG.
Comment 8 Mike Massonnet editbugs 2012-07-10 15:35:08 CEST
It's almost a duplicate of bug 8959. However there won't be a 0px padding, it will be 1px for a panel size < 26px and 2px otherwise.

That there are options in other plugins is the fact that developers are free to add options like they wish, but it's encouraged to use a common guide.

*** This bug has been marked as a duplicate of bug 8959 ***
Comment 9 Miguel Guedes 2012-07-10 20:30:05 CEST
> That there are options in other plugins is the fact that developers are free to 
> add options like they wish, but it's encouraged to use a common guide.

I did this precisely because other plugins - cpugraph, for instance - give users the option to disable margins and maximise their vertical space. In my case I have netload just to the left of cpugraph (with no margin/border) and it just looked like it didn't fit; one was narrower than the other; netload kind of looked crippled. So I had two options: either disable the margin in the cpugraph plugin or create an option in netload. The former was simpler but we'd gain nothing and I'd lose out on vertical space (my panel has only just the needed amount of vertical pixels and no more; so quite narrow) as the cpugraph would look narrower (and sort of crippled like netload); the latter option serves two purposes: users with narrow panels can make the best of what vertical space they have and the plugin is enriched with an option. An option, which in my view, empowers the user rather than impose a way of thinking. 

BTW, the margin is on by default in full conformity with the HIG; user has to explicitly disable it.

Bug #9074

Reported by:
Miguel Guedes
Reported on: 2012-07-02
Last modified on: 2012-07-15

People

Assignee:
Florian Rivoal
CC List:
3 users

Version

Attachments

Additional information