! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
make xfce4-eyes-plugin independent pupil management
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-eyes-plugin
Component:
General

Comments

Description Ikonta 2012-06-17 11:21:22 CEST
Created attachment 4509 
X.Org xeyes application view

Like it os done in X.Org application (see the attached image).
Comment 1 Ikonta 2012-06-17 11:23:56 CEST
Created attachment 4510 
xfce4-eyes-plugin-4.4.1-r1 example

Currently (xfce-extra/xfce4-eyes-plugin-4.4.1-r1) the both pupils behaviour looks to be managed by the left one.
Example in opposite to requested behaviour is attached.
Comment 3 Andrzej editbugs 2013-03-03 03:05:57 CET
Created attachment 4945 
Patch implementing eye position calculations in 3D coords

Current behavior is better but it still feels unnatural. This is mostly because the eye balls are in the same x-y plane as the mouse pointer.

The attached patch calculates 3D angles of the eye sight as if the eye ball was slightly behind the screen (at the moment the distance is hardcoded to 3x eyeball radius). Smaller z distance makes the eyeballs more independent, larger - increases the (x-y) tracking distance (the eyes remain in their center position longer).
Comment 4 Andrzej editbugs 2013-03-03 03:11:26 CET
A comment, possibly invalid:

The very first time I tried the plugin from master branch (in a deskbar mode) it calculated the eye ball position as if the eye ball was shifted to the left by ~30-40px (to the left edge of the plugin).

After rebuilding the plugin and restarting the panel this issue went away, so it might have been some setup problem on my side.
Comment 5 Harald Judt 2013-03-03 09:49:25 CET
Thanks, this is indeed an improvement. Tested with all themes, works fine. The 3x distance seems to be a good default.

http://git.xfce.org/panel-plugins/xfce4-eyes-plugin/commit/?id=88c2ec822210f0efa7ee2b6c99bc4747bf3fd71d
Comment 6 Harald Judt 2013-03-04 12:08:09 CET
Fixed in 4.4.2.

Bug #9036

Reported by:
Ikonta
Reported on: 2012-06-17
Last modified on: 2013-03-04

People

Assignee:
Florian Rivoal
CC List:
2 users

Version

Attachments

Additional information