! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Context-menu icon "fullscreen" naming inconsistency


Description Simon Steinbeiss editbugs 2012-05-30 15:37:38 CEST
Created attachment 4478 
Fullscreen icon is scaled, while maximize isn't

With the new feature of customizable context-menu icons (installed in hicolor/22x22/actions/xfce-wm*) I noticed that the "fullscreen" and "leave fullscreen" icons are identical (see http://git.xfce.org/xfce/xfwm4/tree/src/menu.c#n56 and the following line).

While this might not pose a problem in itself (you could argue that in fullscreen-mode this menu isn't really visible), i'm not sure the naming makes sense. Either Xfwm follows Gnome, but in this case it should use "gtk-leave-fullscreen" for MENU_OP_UNFULLSCREEN (http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html), or it follows the freedesktop.org icon specification(http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html), in which case the correct name of the icon/s would be "view-fullscreen".

Feel free to call me petty for worrying about such a small detail, but maintain an icon theme for more than 6 months and you'll see how annoying inconsistencies can be in this respect :)

A second issue that probably should go into a different bugreport: somehow the icon-scaling is different for the gtk-fullscreen icon. I simply created a symlink for testing in hicolor/22x22/actions from maximize to gtk-fullscreen, and for some reason the fullscreen icon gets scaled down. (Screenshot attached)
Comment 1 Git Bot editbugs 2020-05-29 11:50:12 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/81.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #8971

Reported by:
Simon Steinbeiss
Reported on: 2012-05-30
Last modified on: 2020-05-29


Olivier Fourdan
CC List:
0 users




Fullscreen icon is scaled, while maximize isn't (12.32 KB, image/png)
2012-05-30 15:37 CEST , Simon Steinbeiss
no flags

Additional information