! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Make label spacing consistent with that of other plugins
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-diskperf-plugin
Component:
General

Comments

Description Harald Judt 2012-05-26 16:57:33 CEST
Created attachment 4464 
xfce4-diskperf-plugin-border.patch

The defined "BORDER" is used for various widgets, even in the configuration
dialog, and I think it's cleaner to rework this a little. Why should
someone expect the plugin border of a configuration dialog widget or the
sizes of the progress bars be influenced when trying to change the border
of the main plugin box or vice-versa?

Therefore define the plugin border, label border and progress bar size
separately and optimize the label border to be consistent with other plugins (label spacing 2px), and not making the label look 'stuck' to the progress bars.

Note: The some_BORDER variables now represent the real values of the border,
you don't have to calculate them by dividing the value or do other
calculations.
Comment 1 Landry Breuil editbugs 2013-09-14 10:29:55 CEST
I think this has been mostly implemented in http://git.xfce.org/panel-plugins/xfce4-diskperf-plugin/commit/?id=c155f4c6c9822c087dabe71e454fc0243454d504 .. harald, maybe we can close this bug ? Or there are more tweaks to apply ?
Comment 2 Harald Judt 2013-09-14 13:18:11 CEST
Yes, I think so. Looks fine to me.
Comment 3 Harald Judt 2013-09-14 13:18:27 CEST
Closing.

Bug #8950

Reported by:
Harald Judt
Reported on: 2012-05-26
Last modified on: 2013-09-14

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Attachments

Additional information