Created attachment 4430
change minimum inactivity to 8 minutes
I think the inactivity slider should be a bit more considerate. I suggest 8 minutes instead of 15. 8 may be crazy short for some people, but I think we should give users the freedom to do whatever they want.
I think my patch works, but I haven't tested it.
Created attachment 4431
also make appropriate canges to the UI and settings
Perhaps there are more changes to be made than I initially thought. Maybe this should be enough.
Created attachment 4432
change minimum inactivity to 8 minutes - version 3
In my second patch I accidentally made inactivity time on battery default to "never" (value set to 7). This changes it back to what it was before (15 minutes).
This should be solved in >=1.4 and later (complete rework of this stuff).
This bug is not fixed (1.4.2). Please re-open this report!
Reopened because it fell victim to my bug cleaning without being fixed.
sankeytms: is there any chance that you rebase your patch on the new xfce4-power-manager (git trunk)? It has undergone a rewrite and I'm not sure your patch would still apply.
If you're satisfied that you have a working patch, I will test it for you and nag the developers to have it released.
Created attachment 5917
lowers the minimum inactivity duration from 14 to 4 minutes
Here you go. This one even allows down to 5 minutes. I lightly tested it, and it seems to work. For convenience, here are the commands to fetch the relevant properties from the relevant channels (for testing):
$ xfconf-query --channel xfce4-power-manager -p /xfce4-power-manager/inactivity-on-battery
$ xfconf-query --channel xfce4-power-manager -p /xfce4-power-manager/inactivity-on-ac
Created attachment 5918
inactivity slider now uses exponential scale
This is only slightly related, but it caught my attention because testing the previous patch was awkward. IIRC, OS X (or GNOME 3, I don't quite remember) has some of their inactivity sliders on an exponential scale. This is much more user-friendly IMO. This patch adds that feature to the inactivity sliders, with an exponent of 2.0, giving more fine-tuned control between 4 and 60 minutes.
Thanks for the new patches! I tested on ArchLinux 3.18 64Bits and the exponential slider feels *much* better to use. You're on the way to making a very nice contribution :-) A couple of comments below:
- Somehow I cannot go further than 5h40. Is that expected? I would have expected 6 hours (old GUI was 5h50). Could you please round this to 6?
- Keyboard navigation should always increment by at least one. You could make the keyboard event handler move the slider by several increments until it reaches a higher mapped value, though that would be computationally wasteful. Ideally, computed the next mapped slider value that should be used from the existing value in one calculation
- pow is supported on _BSD_SOURCE || _SVID_SOURCE || _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || _POSIX_C_SOURCE >= 200112L; @Core Developers, Distributors: is there a system for which using pow would be a problem?
- Could you please create a DEFINE for the min and max values in the code? And then, when storing to xfconf, could you please map the min/"Never" value to 0 instead of what it actually is? And when you load 0 from Xfconf, map it to whichever slider value will show "Never" See below for why
- @XFPM Maintainers: Distributors must be warned that they *must* map existing Xfconf keys valued 14 onto a value of 0 or 4 from now on. This is because 14 means "Never" (it's below the minimum which is 15). However, when shortening the min delay to 4, 14 is then read like a normal valid duration.
In an ideal world, you would provide a patch for:
- moving from 14 to a defined value, and handling the storing 0 in xfconf bit
- replacing the existing 15 minutes by 5 minutes (and also to change the values in the .ui for which you can't rely on a define)
- implementing the logarithmic slider with working keyboard navigation
This way if developers want to delay changing the minimum slider value (because of the 14 minute glitch), they can still apply your other changes.
-- GitLab Migration Automatic Message --
This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/3.
Please create an account or use an existing account on one of our supported OAuth providers.
If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests
Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev